Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covariant ReadOnlyView #326

Open
conradludgate opened this issue Feb 1, 2025 · 0 comments
Open

Covariant ReadOnlyView #326

conradludgate opened this issue Feb 1, 2025 · 0 comments

Comments

@conradludgate
Copy link
Contributor

ReadOnlyView is currently invariant over <K, V>. I've had at least one person ask me for help with this problem, and that's 1 more than I ever expected.

https://github.com/obi1kenobi/trustfall-rustdoc-adapter/compare/dashmap_issue

In my testing, removing the RwLock from the internals of ReadOnlyView fixes the above linked test case.

However, removing the RwLock requires a re-allocation. conradludgate@5e3afd8

Raising this issue to track whether this cost is acceptable, or if there's another work around, or if this is a "wontfix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant