Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gap between breadcrumbs #6

Open
stephcathoh opened this issue Sep 21, 2023 · 3 comments
Open

Change gap between breadcrumbs #6

stephcathoh opened this issue Sep 21, 2023 · 3 comments
Labels
🧪 Enhancement Spinning up new features in the lab.

Comments

@stephcathoh
Copy link

I would love an option to change the gap between breadcrumbs

@justintadlock justintadlock added the 🧪 Enhancement Spinning up new features in the lab. label Sep 21, 2023
@justintadlock
Copy link
Contributor

justintadlock commented Sep 21, 2023

There's an issue with the way blockGap works for blocks that don't support layout. I'll have to look up the Gutenberg ticket (not sure if it's fixed yet).

In the meantime, it's possible to set the gap manually via settings.custom.x3p0Breadcrumbs.gap in theme.json.

@stephcathoh
Copy link
Author

Thanks for this explanation. The Breadcrumb Block plugin has an option for changing the gap. Both your plugin and that plugin are great - a perfect plugin for me would offer a "marriage" of the features in both. I will see if JSON settings will work. I'm turning a classic theme into a hybrid theme and there has been some wonkiness.

@justintadlock
Copy link
Contributor

Yep, it's using a custom implementation for the gap instead of the standard WordPress blockGap feature. I'm guessing the author went the custom route for the same reason I opted out of adding it to this plugin.

Anyway, it's on my radar, and it'll definitely be added when blockGap support is fixed for custom blocks using the standard method. Here's the ticket that I'm waiting on: WordPress/gutenberg#53155


Side note: the Breadcrumb Block plugin actually uses an outdated version of this plugin's PHP code. That reminds me that I need to contact its author and see if I can convince him to upgrade that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 Enhancement Spinning up new features in the lab.
Projects
None yet
Development

No branches or pull requests

2 participants