Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Environment" class for configuring the breadcrumbs #3

Closed
justintadlock opened this issue Jul 18, 2023 · 0 comments
Closed

Add "Environment" class for configuring the breadcrumbs #3

justintadlock opened this issue Jul 18, 2023 · 0 comments
Assignees
Labels
🧪 Enhancement Spinning up new features in the lab.

Comments

@justintadlock
Copy link
Contributor

There are many ways that the various classes can be extended or overwritten on the PHP end. However, they are still a bit clunky. In fact, I removed a few filter hooks for version 1.0 to deter others from extending them in one way.

Ideally, we'd have an Environment class for configuring which Query, Build, and Crumb classes are used. Filters could even be run at this point for easy extension. Overall, the goal would be to make it easier for build on top of the system for more complex plugins with unique URL structures by just passing in a set of custom classes.

This is probably not explained well here in this ticket, but some preliminary stuff exists for this in my head and a local notes file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 Enhancement Spinning up new features in the lab.
Projects
None yet
Development

No branches or pull requests

1 participant