Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up when upgrading to node18 images: Dockerignore now works #79

Open
badrange opened this issue Feb 7, 2023 · 0 comments
Open

Comments

@badrange
Copy link
Contributor

badrange commented Feb 7, 2023

This is not a bug, but a heads up you could write down in some upgrade guide:

After we merged PR where we upgraded to the new node 18 silta images we had an issue where sso didn't work. It turned out that an env var was missing, and after a bit of digging I realized that the missing env var used to live in nexts' .env.local file (it was generated in CircleCI).

A lot of head scratching later I realized that the .env.local file was missing because of a match in dockerignore.

So what has changed is that Dockerignore has started working, but it didn't before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant