-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routine Status Checks #30
Comments
I'm against this. This leads to "alert spam" and people will just ignore the message. It's better to let the bot emit metrics, e.g. use Prometheus |
Yeah, metrics are fine, too and offer more insight on where we might improve the project. I second this. |
I think, prometheus might be a bit of an overkill for our little project. Maybe let's collect ideas first what data we want the bot to emit regularly? Right now i can think of:
|
I'd like to have the option to see a list of all subscribers sorted by subscription date. |
Let me explain my reasoning for Prometheus and against any type of push based system in this case. Sorry for the wall of text ahead. We should really first think about what do we need this information for:
In any case we need to instrument the the code with some sort of library to actually extract the metrics. This is known as white-box monitoring, so we're extracting it directly from the running application. This usually requires some sort of async loop running alongside the main logic loop and a new web endpoint like
I disagree:
Why I'm against a push based system via messages to admins: Alarm fatigue: sending those messages will lead to a lot of spam essentially and people will start ignoring it after a while. Also in 90% of those messages nothing will change; imagine you wake up in the morning and have received 20 messages from the bot which you now have to all look through and realise nothing has changed over the night. You do this three nights and the you just ignore them. Then people will request to stop sending all those messages and we need to think of a mechanism to turn them off again (but just for some people?) which will require more custom logic. This is a lot of complexity for very little return. Also imagine we're pushing every 30 minutes: how can we tell that the bot hasn't been down from minute 10 to minute 25 ? And if we wake up in the morning and expect 10 messages but there are only 7, what do we do? Is this actionable information we can use? This is what I would do:
This could be done with a simple database query. Alternatively we can think of a |
The text was updated successfully, but these errors were encountered: