Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Project cards should log their own filename #274

Closed
lmz opened this issue Jan 14, 2022 · 5 comments
Closed

[FEATURE] Project cards should log their own filename #274

lmz opened this issue Jan 14, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@lmz
Copy link
Collaborator

lmz commented Jan 14, 2022 •
edited
Loading

User Story

*As a modeler building networks and applying project cards, my logs show things like this:

2022-01-13 16:19:08, INFO: Applying Year 2015 Modify Facility Type to Ramp shape incorrect

What project card is that referring to? I'd rather know what the filename is called than have to search my project cards for that text. What if multiple cards have the same description? (or is that a title?).

I think it would be more useful to say something like:

2022-01-13 16:19:08, INFO: Applying [year_2015_roadway_property_change_should_be_ramp_shape_incorrect.yml]: Applying Year 2015 Modify Facility Type to Ramp shape incorrect

Priority

To me? High ;)

Level of Effort

low

Resolution Ideas

Project

MTC

Who should be involved?

Implementer:
Commenters:
Users:
Reviewers:

Risk

Will this potentially break anything?

Tests

What are relevant tests or what tests need to be created in order to determine that this issue is complete?
@lmz lmz added the enhancement New feature or request label Jan 14, 2022
@e-lo
Copy link
Collaborator

e-lo commented Jan 19, 2022

I agree with your proposed logging change and think this makes sense.

@lmz
Copy link
Collaborator Author

lmz commented Jan 19, 2022

I'm happy to do this (to get familiar with the contributing process) although it looks like I don't think I have permissions to assign the issue. Would I make a pull request to the develop branch? (Or create a feature branch...? The change seems a bit minor for that)

@e-lo
Copy link
Collaborator

e-lo commented Jan 19, 2022 via email

lmz added a commit to BayAreaMetro/network_wrangler that referenced this issue Feb 12, 2022
@lmz
Fixes wsp-sag#274 Project cards should log their own filename
a3bcddd 
on apply
@e-lo e-lo self-assigned this Apr 8, 2022
@e-lo e-lo added this to the v1.0 milestone Apr 8, 2022
@e-lo e-lo removed their assignment Apr 8, 2022
@e-lo
Copy link
Collaborator

e-lo commented Apr 8, 2022

@lmz can you PR that to this repo plz?

@e-lo e-lo mentioned this issue Mar 3, 2023
Closed
@e-lo e-lo linked a pull request Mar 8, 2023 that will close this issue
Log project card filename #314
Closed
@e-lo
Copy link
Collaborator

e-lo commented Aug 27, 2024

Also fixed in v1 now.

@e-lo e-lo closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Log project card filename wsp-sag/network_wrangler
2 participants
@e-lo @lmz