Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error when applying project cards on attributes that are dictionaries #234

Closed
1 task
AshishKuls opened this issue Nov 4, 2020 · 3 comments
Closed
1 task
Labels
enhancement New feature or request

Comments

@AshishKuls
Copy link
Member

Describe the bug

When the user apply a parallel managed lane project card and then apply another project card on the wrangler network, it throws an error.

The reason is that when a managed lane project card is applied, one or more attributes become dictionary segmented by the time of day for certain roadway segments, and then any other change for those attributes wouldn't be possible on the same roadway segments within the wrangler network/environment.

To Reproduce

An example is here - this applies a parallel managed lane card and a roadway property change project card in sequence:

Failing tests

  • No applicable test failed, need to create.

Thoughts on resolution

Two approaches were discussed as a workaround solution:

  • After applying the managed lane project card on wrangler network, export it out as a model network (which will separate out the parallel managed lane) and then read the network back into wrangler to apply any other changes

  • something with writing out .wrangler file.

@AshishKuls AshishKuls added the bug Something isn't working label Nov 4, 2020
@AshishKuls
Copy link
Member Author

@DavidOry Could you please update the second possible approach - doing something with the .wrangler file?

@DavidOry
Copy link
Member

DavidOry commented Nov 5, 2020

Note this issue is broader than post managed lanes card application, as any attribute can be a dictionary.

@DavidOry DavidOry changed the title [BUG] Error when applying any other project card on top of managed lane project card [BUG] Error when applying project cards on attributes that are dictionaries Nov 5, 2020
@DavidOry DavidOry added enhancement New feature or request invalid This doesn't seem right and removed bug Something isn't working invalid This doesn't seem right labels Nov 5, 2020
@e-lo
Copy link
Collaborator

e-lo commented Aug 27, 2024

Now works fine in v1 branch: #327

@e-lo e-lo closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants