Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When activated on a multinetwork, the cache directory url doesn't behave as expected #923

Open
beatelite opened this issue Feb 5, 2018 · 3 comments

Comments

@beatelite
Copy link

beatelite commented Feb 5, 2018

Summary:
When using a multinetwork (multiple multisites on one install), enabling cometcache for each network, and creating a separately name-spaced cache directory for each network, comet cache switches the url for each site arbitrarily.

Basically, sometimes networks will use other network's url path which means clearing cache sometimes won't work because you may not be using a cache path that's relative your site's network.

This is weird because, while multi-networks may sound exotic, they are simply multiple vanilla multisite networks and every other multisite compatible plugin on the market ( except CC) behaves as expected in this environment - by only working on the network they're installed on.

Reproduction steps:

  • Set up a mutlinetwork with two to three networks ( we have 3)
  • Create a couple sites on each network
  • network-enable Comet Cache on each network's main site
  • Set the cache directory for each network using a different name space (e.g /cache/network1 .. /cache/network2 ... /cache/network3 etc)
  • save settings
  • go to a bunch of subsites of each network in incognito browser to set the cache for the site
  • check the inspector for the browser and note where the url for the comet cache directory is (it should be the url set for the the network settings that the site is a part of )
  • now wipe the cache for that network and check the site again

Current results:
Either the cache won't wipe because Comet Cache is using another network's url for cache or, if it does wipe, the subsite will somehow get another network's url for cache and you'll have to wipe THAT network's cache in order for the cache to clear.

Expected results
For every site to be able to have it's cache cleared when wiping the cache for that particular site OR when the cache is cleared for it's main network (not another network - which is happening now).

This is a particular problem when using page builders. When you try to clear the cache programmatically after a page save, the cache wont clear. This is because the plugin is looking in it's own network (as expected) for Comet Cache but Comet Cache may not have a cache to clear because it's using another network's cache url. We can't reach across networks with plugins to clear another network's cache so this is really frustrating.

We have a valid top license for CC and hope to get this resolved quickly.

@jaswrks
Copy link

jaswrks commented Feb 8, 2018

Thank you very much for this report. I don't believe we have tested in a multinetwork environment yet, so we should definitely do that. cc @raamdev

@beatelite
Copy link
Author

Thanks, let me know if I can do any testing.

@beatelite
Copy link
Author

Any word on this? I now find I have to totally disable the plugin as it's causing all kinds of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants