From fbbd2ff7ef5e39ca73df01f5cc02b747efc739ad Mon Sep 17 00:00:00 2001
From: Micah Wood <micah@wpscholar.com>
Date: Tue, 30 Apr 2019 16:59:44 -0400
Subject: [PATCH] Make standards easier to install. Set smarter defaults and
 ignore a few things that aren't important when not working on core.

---
 WPScholar/ruleset.xml | 34 ++++++++++++++++++++++++----------
 composer.json         |  5 +++--
 2 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/WPScholar/ruleset.xml b/WPScholar/ruleset.xml
index feb188c..df408b2 100644
--- a/WPScholar/ruleset.xml
+++ b/WPScholar/ruleset.xml
@@ -2,7 +2,15 @@
 <ruleset name="WPScholar">
     <description>The WP Scholar PHP Code Sniffer standard.</description>
 
-    <config name="installed_paths" value="../../phpcompatibility/php-compatibility,../../wp-coding-standards/wpcs"/>
+    <arg name="colors"/>
+
+    <config name="testVersion" value="5.6-"/>
+
+    <!-- Sets the minimum supported WP version to 4.7, which is over a year old. -->
+    <config name="minimum_supported_wp_version" value="4.7"/>
+
+    <!-- For CI, don't fail on warnings -->
+    <config name="ignore_warnings_on_exit" value="1"/>
 
     <exclude-pattern>*/phpunit.xml*</exclude-pattern>
     <exclude-pattern>*/languages/*</exclude-pattern>
@@ -32,12 +40,11 @@
         <severity>0</severity>
     </rule>
 
-    <!-- For CI, don't fail on warnings -->
-    <config name="ignore_warnings_on_exit" value="1"/>
-
-    <!-- Enforce doc standards -->
     <rule ref="WordPress-Docs">
-        <!-- Don't worry about capitolizing long lines -->
+        <!-- Don't worry about page comment blocks -->
+        <exclude name="Squiz.Commenting.FileComment.Missing"/>
+
+        <!-- Don't worry about capitalizing long lines -->
         <exclude name="Generic.Commenting.DocComment.LongNotCapital"/>
     </rule>
 
@@ -56,10 +63,16 @@
 
         <!-- Comment punctuation doesn't matter -->
         <exclude name="Squiz.Commenting.FunctionComment.ParamCommentFullStop"/>
-    </rule>
 
-    <!-- Sets the minimum supported WP version to 4.7, which is over a year old. -->
-    <config name="minimum_supported_wp_version" value="4.7"/>
+        <!-- Allow usage of short echo tag, but not short open tags -->
+        <exclude name="Generic.PHP.DisallowShortOpenTag.EchoFound"/>
+
+        <!-- Allow snake case -->
+        <exclude name="WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid"/>
+        <exclude name="WordPress.NamingConventions.ValidVariableName.PropertyNotSnakeCase"/>
+        <exclude name="WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase"/>
+        <exclude name="WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase"/>
+    </rule>
 
     <!-- Make missing translator comment a warning. -->
     <rule ref="WordPress.WP.I18n.MissingTranslatorsComment">
@@ -72,5 +85,6 @@
     </rule>
 
     <!-- Loads the PHP Compatibility ruleset. -->
-    <rule ref="PHPCompatibility"/>
+    <rule ref="PHPCompatibilityWP"/>
+
 </ruleset>
diff --git a/composer.json b/composer.json
index 1353c8f..56d298e 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "wpscholar/phpcs-standards-wpscholar",
   "description": "PHP Code Sniffer Standards for WP Scholar",
-  "type": "phpcs-standards",
+  "type": "phpcodesniffer-standard",
   "license": "GPL-2.0-or-later",
   "authors": [
     {
@@ -13,6 +13,7 @@
     "squizlabs/php_codesniffer": "@stable",
     "phpcompatibility/php-compatibility": "@stable",
     "wp-coding-standards/wpcs": "@stable",
-    "wpscholar/phpcs-standards-installer": "@stable"
+    "dealerdirect/phpcodesniffer-composer-installer": "@stable",
+    "phpcompatibility/phpcompatibility-wp": "@stable"
   }
 }