Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build.gradle uses obsolete CMake flags for NEON and VFP #68

Open
mdurrani808 opened this issue Dec 16, 2022 · 4 comments
Open

Build.gradle uses obsolete CMake flags for NEON and VFP #68

mdurrani808 opened this issue Dec 16, 2022 · 4 comments

Comments

@mdurrani808
Copy link
Contributor

opencv/opencv#18244

https://github.com/opencv/opencv/blob/422f802ec96feecbc9db2f60879e8fe364cf8a92/cmake/OpenCVCompilerOptimizations.cmake#L101-L102

Still have to figure out how to check if NEON and VFP are getting enabled or not

@mdurrani808 mdurrani808 changed the title Build uses obsolete CMake flags for NEON and VFP Build.gradle uses obsolete CMake flags for NEON and VFP Dec 16, 2022
@mdurrani808
Copy link
Contributor Author

Not sure if I'm off base here or not to be completely honest.
This shows up in the logs:
-- Performing Test HAVE_CPU_NEON_SUPPORT (check file: cmake/checks/cpu_neon.cpp)
-- Performing Test HAVE_CPU_NEON_SUPPORT - Failed

@rzblue
Copy link
Member

rzblue commented Dec 16, 2022

Logs from where?

The latest CI for arm64 says otherwise: https://github.com/wpilibsuite/thirdparty-opencv/actions/runs/3579760056/jobs/6021264064#step:5:189

@mdurrani808
Copy link
Contributor Author

Athena and Arm32, is NEON not supported on those?
On arm64 it also says
disabled: VFPV3

@ThadHouse
Copy link
Member

Arm64 wouldn’t have vfpv3 anyway. Arm64 is guaranteed to have floating point and vectorization support.

Athena does have neon and vfpv3.

Normal arm32 is a special case. It’s optional on the cpu. I don’t know what we have the build set up for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants