Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using iwyu #210

Open
noamzaks opened this issue Jul 17, 2021 · 1 comment
Open

Using iwyu #210

noamzaks opened this issue Jul 17, 2021 · 1 comment

Comments

@noamzaks
Copy link

The following tool may be useful:

iwyu

@calcmogul
Copy link
Member

calcmogul commented Jul 17, 2021

I tried this in https://github.com/calcmogul/allwpilib/tree/include-what-you-use a month ago, and I rebased it today. I had to make manual fixes afterward to most files because it would:

  1. Include system internal headers that throw errors if you include them directly.
  2. Include headers that don't exist on some platforms.
  3. Include internal Eigen headers that don't compile unless other headers are included first. (I guess Eigen doesn't include what it uses. 🙂)
  4. Put forward declarations of the same type in both the header and source, then fail to actually include the header containing the type in the source file.

I'm still not exactly happy with the contents of that branch yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants