From 6db225b0e8820b836b8fb89ffed3bead2439a367 Mon Sep 17 00:00:00 2001 From: Itay Ziv Date: Thu, 3 Feb 2022 02:52:37 +0200 Subject: [PATCH] Revert relative url behaviour --- sphinxext/opengraph/__init__.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sphinxext/opengraph/__init__.py b/sphinxext/opengraph/__init__.py index 9724ae3..3e69994 100644 --- a/sphinxext/opengraph/__init__.py +++ b/sphinxext/opengraph/__init__.py @@ -114,12 +114,6 @@ def get_tags( ogp_use_first_image = config["ogp_use_first_image"] ogp_image_alt = fields.get("og:image:alt", config["ogp_image_alt"]) - if image_url: - image_url_parsed = urlparse(image_url) - if not image_url_parsed.scheme: - # Relative image path detected. Make absolute. - image_url = urljoin(config["ogp_site_url"], image_url_parsed.path) - fields.pop("og:image:alt", None) if ogp_use_first_image: @@ -132,6 +126,11 @@ def get_tags( ogp_image_alt = first_image.get("alt", None) if image_url: + if image_url: + image_url_parsed = urlparse(image_url) + if not image_url_parsed.scheme: + # Relative image path detected. Make absolute. + image_url = urljoin(config["ogp_site_url"], image_url_parsed.path) tags["og:image"] = image_url # Add image alt text (either provided by config or from site_name)