Make deprecations produce errors in WPILib builds #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we turned this off explicitly because in some cases there's no way to suppress the deprecation warning. |
|
We've been using the WPI_IGNORE_DEPRECATED and WPI_UNIGNORE_DEPRECATED macros to suppress deprecated calls we have to make internally. allwpilib already removes the |
|
We remove it only for RoboRIO targets? https://github.com/wpilibsuite/allwpilib/blob/main/shared/config.gradle#L58-L63 |
|
I think that was an oversight by me. We build everything for athena, so it caught all the instances of unsuppressed deprecation warnings. |
PeterJohnson
approved these changes
Sep 25, 2023
calcmogul
deleted the
make-deprecations-produce-errors-in-wpilib-builds
branch
calcmogul
restored the
make-deprecations-produce-errors-in-wpilib-builds
branch
calcmogul
deleted the
make-deprecations-produce-errors-in-wpilib-builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.