Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for persistent alerts #2711

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

jwbonner
Copy link
Member

Documentation for the new alerts API and widget.

@jasondaming
Copy link
Member

I think the link is failing because if you want to use the "new" syntax I think you might need the full link. So either revert to the old style or change it to the full link and see if that works. See this section

@jwbonner
Copy link
Member Author

jwbonner commented Aug 31, 2024

I switched to the full link. Even with the old syntax I think it fails because the Python class doesn't exist yet.

Also failing on the full link because it 404s. Not sure how to handle that beyond just adding the robotpy bindings first...

@jasondaming
Copy link
Member

Yeah makes sense I guess we just wait then till that happens. This looks ready to go otherwise to me.

jasondaming
jasondaming previously approved these changes Aug 31, 2024
@sciencewhiz
Copy link
Collaborator

I think I'd prefer to merge without a python link, and open an issue to have it added later when available.

@sciencewhiz sciencewhiz merged commit 28ca100 into wpilibsuite:main Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants