Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate experimental app router package for testing/building #1640

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Nov 9, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

This PR isolates the experimental app router package into its own workflow since this project now requires a minimum of node 18. Since our other packages run on Node 16, the workflows were modified to not build/test this package within the default scripts, and only do it in it's own experimental-app-router.yml workflow.

Additionally, engine-strict was turned off since running npm ci at the root would fail instantly since one of the packages required an out of date engine (i.e. when running workflows on node 16, npm ci would fail because the app router package had engines set to node 18.

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner November 9, 2023 14:23
Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: bb7222d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@blakewilson blakewilson merged commit 04ced90 into canary Nov 9, 2023
18 checks passed
@blakewilson blakewilson deleted the experimental-app-router-workflows branch November 9, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants