Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Faust uploads missing block files with blockset command #1633

Closed
JEverhart383 opened this issue Nov 7, 2023 · 5 comments · Fixed by #1656
Closed

Bug: Faust uploads missing block files with blockset command #1633

JEverhart383 opened this issue Nov 7, 2023 · 5 comments · Fixed by #1656
Labels
type: bug Issue that causes incorrect or unexpected behavior

Comments

@JEverhart383
Copy link

When running blockset against a WP Engine hosted WP install, only the block.json file appears to sync. A user reported this in this thread from Discord, and I was able to reproduce using my own site here: https://faustintl.wpengine.com/

Everything appears to look like it should in .faust directory, but accessing wp-uploads/faust/blocks only lists the block.json file, and the block is not available in the editor.

Screenshot_2023-11-07_at_9 51 56_AM Screenshot_2023-11-07_at_9 52 35_AM

The same steps in Local appear to do what I expect, and I can sync and use the block:
Screenshot_2023-11-07_at_10 10 16_AM

Applicable Versions

WordPress: 6.3.1
Faust WordPress Plugin: 1.1.0
WPGraphQL: 1.18.0
@faustwp/core: 1.2.0
@faustwp/cli: 1.2.0

  • WordPress version:

Steps To Reproduce

  1. Follow the instructions outlined in this guide: https://faustjs.org/tutorial/react-components-to-gutenberg-blocks

  2. Sync blocks to a remote WP install on WP Engine using blockset

  3. Access wp-uploads via FTP to see missing files

Link to code example:

https://github.com/JEverhart383/faust-intl/tree/feature/blockset

The current behavior

Block sync against a remote WP Engine install fails

The expected behavior

I should be able to use the block the same way I do on Local

@mindctrl mindctrl added type: bug Issue that causes incorrect or unexpected behavior has jira labels Nov 7, 2023
@theodesp
Copy link
Member

theodesp commented Nov 8, 2023

Pinging @josephfusco so that we can take a look. It may be related to WP Engine security rules.

@theodesp
Copy link
Member

theodesp commented Nov 8, 2023

It might be a possible firewall rule since when I run the blockset command I get this response:

"faust blockset" failed with the following error: Error: Network error: Error parsing response from WordPress.
    at uploadToWordPress (file:///Users/theo.despoudis/Workspace/atlas-blueprint-blueset/node_modules/@faustwp/cli/dist/blockset.js:104:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async blockset (file:///Users/theo.despoudis/Workspace/atlas-blueprint-blueset/node_modules/@faustwp/cli/dist/blockset.js:149:9)
    at async file:///Users/theo.despoudis/Workspace/atlas-blueprint-blueset/node_modules/@faustwp/cli/dist/index.js:74:13

This is with no public route redirects setting on.

I can see the blockset endpoint being accessed with 200 in the WP Engine Access logs

Screenshot 2023-11-08 at 12 00 02

@theodesp
Copy link
Member

theodesp commented Nov 9, 2023

@JEverhart383 We have identified the issue and we are working on a solution.

@josephfusco
Copy link
Member

I have a PR open with a proposed fix

Also wanted to note that the block-support example project seems to be having issues.
Screenshot 2023-11-14 at 11 36 53 AM

@josephfusco
Copy link
Member

Ready for another review! :)
#1656

@josephfusco josephfusco linked a pull request Nov 17, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue that causes incorrect or unexpected behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants