Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18 - Backend and filesystem part #7062

Open
piotrbak opened this issue Oct 27, 2024 · 0 comments · May be fixed by #7083
Open

3.18 - Backend and filesystem part #7062

piotrbak opened this issue Oct 27, 2024 · 0 comments · May be fixed by #7083
Assignees
Labels
type: new feature Indicates the issue is a request for new functionality
Milestone

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Oct 27, 2024

User Story
As a user, I’d like to host Google Fonts locally to better control the fonts and improve LCP.

Acceptance Criteria

  • The content of combined Google Fonts CSS file will be saved into the local CSS file, we'll name the CSS with the value of the original URL hash and save it into the path like we do for Used CSS: (2/e/4/h/aerw32eweq.css)
  • The feature will handle V1 and V2 separately
  • The feature will automatically copy combined CSS files in a sub-folder under wp-content, specifically /wp-content/cache/wp-rocket/fonts/google-fonts/
  • The feature will rewrite URLs of the fonts found in the CSS file into the local path
  • The feature will download fonts to the path that would preserve the original URL structure in the /fonts/ directory: /wp-content/cache/wp-rocket/fonts/google-fonts/fonts/s/caudex/v17/esDS311QOP6BJUr4yMKPtbo-Ew.woff2 (input: https://fonts.gstatic.com/s/caudex/v17/esDS311QOP6BJUr4yMKPtbo-Ew.woff2)
  • The feature will create structure correctly for the multisites

Comment

  • Be sure to deliver testable output, to be enabled with the pre_rocket_get filter
@piotrbak piotrbak added the type: new feature Indicates the issue is a request for new functionality label Oct 27, 2024
@piotrbak piotrbak added this to the 3.18 milestone Oct 27, 2024
Khadreal added a commit that referenced this issue Oct 31, 2024
@Khadreal Khadreal self-assigned this Nov 1, 2024
@Khadreal Khadreal linked a pull request Nov 1, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new feature Indicates the issue is a request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants