Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin - Accommodate new oneclick exclusions UI for delayjs #7075

Open
jeawhanlee opened this issue Oct 28, 2024 · 2 comments · May be fixed by #7090
Open

Plugin - Accommodate new oneclick exclusions UI for delayjs #7075

jeawhanlee opened this issue Oct 28, 2024 · 2 comments · May be fixed by #7090
Assignees
Labels
effort: [S] 1-2 days of estimated development time
Milestone

Comments

@jeawhanlee
Copy link
Contributor

jeawhanlee commented Oct 28, 2024

Is your feature request related to a problem? Please describe.
Accommodate the new structure from the backend exclusion lists to fit the new UI.
Parent issue

Describe the solution you'd like
Update the UI to fit new changes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jeawhanlee jeawhanlee added the effort: [S] 1-2 days of estimated development time label Oct 28, 2024
@jeawhanlee
Copy link
Contributor Author

Scope a solution ✅

In WP_Rocket\Engine\Optimization\DelayJS\Admin\SiteList::prepare_delayjs_ui_list

  • Update this array to add the new categories described here
  • Update the same array to use new Category headings ( 3rd parties for scripts & WordPress for themes and plugins )
  • Update each subcategory head to display a counter that shows the number of active exclusions.

In views/settings/fields/categorized_multiselect.php

  • Move this to this list, might need to update this part of this script
  • Add new css rule to override style for wpr-field to make divider short
  • Update this to allow for clicking on the subcategory title to toggle list.

In WP_Rocket\Engine\Admin\Settings

  • Update wording here to the proposal here

Add tests.

Estimate the effort ✅

[S]

@Miraeld
Copy link
Contributor

Miraeld commented Oct 29, 2024

LGTM

@piotrbak piotrbak added this to the 3.18 milestone Oct 29, 2024
@jeawhanlee jeawhanlee self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [S] 1-2 days of estimated development time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants