Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CNAME and load state timeout value configurable. #39

Open
jeawhanlee opened this issue Nov 15, 2023 · 0 comments
Open

Make CNAME and load state timeout value configurable. #39

jeawhanlee opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jeawhanlee
Copy link
Contributor

jeawhanlee commented Nov 15, 2023

Is your feature request related to a problem? Please describe.
Since the CNAME is hardcoded, we will not have the privilege of flexible testing with any CNAME whenever there is a need for this, as well as the timeout as we could have cases where page load could take longer than expected.

Describe the solution you'd like
We should replace all the occurrence of hardcoded CNAME and waitForLoadState timeout with a constant in the config file.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jeawhanlee jeawhanlee added the enhancement New feature or request label Nov 15, 2023
@jeawhanlee jeawhanlee changed the title Make CNAME value configurable. Make CNAME and load state timeout value configurable. Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant