Skip to content

Commit 82e3dd3

Browse files
Fix failing PHP 5.6 tests by requiring WP 5.2 (#342)
The WordPress importer changed its minimum supported WP version to 5.2, which means these tests never receive an update offer in WP 3.7. It looks like all "official" plugins no longer support WP 3.7, so there isn't really anything we can replace with.
1 parent 34a48f8 commit 82e3dd3

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

features/plugin-update.feature

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
Feature: Update WordPress plugins
22

3+
@require-wp-5.2
34
Scenario: Updating plugin with invalid version shouldn't remove the old version
45
Given a WP install
56

@@ -45,6 +46,7 @@ Feature: Update WordPress plugins
4546
"""
4647
And the return code should be 1
4748

49+
@require-wp-5.2
4850
Scenario: Exclude plugin updates from bulk updates.
4951
Given a WP install
5052

@@ -76,6 +78,7 @@ Feature: Update WordPress plugins
7678
Update available
7779
"""
7880

81+
@require-wp-5.2
7982
Scenario: Update a plugin to its latest patch release
8083
Given a WP install
8184
And I run `wp plugin install --force wordpress-importer --version=0.5`
@@ -109,6 +112,7 @@ Feature: Update WordPress plugins
109112
2.6.1
110113
"""
111114

115+
@require-wp-5.2
112116
Scenario: Not giving a slug on update should throw an error unless --all given
113117
Given a WP install
114118
And I run `wp plugin path`
@@ -229,7 +233,7 @@ Feature: Update WordPress plugins
229233
"""
230234
And the return code should be 0
231235

232-
236+
@require-wp-5.2
233237
Scenario: Updating all plugins with some of them having an invalid version shouldn't report an error
234238
Given a WP install
235239

features/plugin.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,7 @@ Feature: Manage WordPress plugins
341341
| akismet | active | akismet/akismet.php |
342342
| wordpress-importer | inactive | wordpress-importer/wordpress-importer.php |
343343

344+
@require-wp-5.2
344345
Scenario: Flag `--skip-update-check` skips update check when running `wp plugin list`
345346
Given a WP install
346347

0 commit comments

Comments
 (0)