You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The Problem is the small difference between an Export JSON and Export CLI (as far as i could see).
It would be much easier to export an Raid for the CLI. If an JSONexport is used, the CLI wird hard crash, due to
(Given JSON is parsed into an RaidSimRequest but its missing the simOptions field, so that check will try to point something in nil)
Describe the solution you'd like
The Export -> CLI Option for the Raid Sim UI
Describe alternatives you've considered
Implement a small scripting myself wich removes the setting Object inside the JSON and uses the information from it to build an simOptions Object.
Additional context
I mostly noted that things because i tried to Import an "normal" JSON instead of the CLI JSON, which resulted in the CLI crashing. at first i was not confident enough to say thats maybe a Layer 8 problem, but after checking basic differences of the JSON's and the code of the CLI, i noticed that these both exports are different, if not completly.
I would try to help you there, but im not that into deep into that project and don't currently know what the do's and don'ts are (specially at frontend side) so i created this ticket instead of an PR. Maybe this is even something that wont be fixed for WotLk but implemented in Cata
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The Problem is the small difference between an
Export JSON
andExport CLI
(as far as i could see).It would be much easier to export an Raid for the CLI. If an JSONexport is used, the CLI wird hard crash, due to
wotlk/sim/core/sim.go
Line 112 in 459db05
(Given JSON is parsed into an
RaidSimRequest
but its missing thesimOptions
field, so that check will try to point something in nil)Describe the solution you'd like
The
Export
->CLI
Option for the Raid Sim UIDescribe alternatives you've considered
Implement a small scripting myself wich removes the
setting
Object inside the JSON and uses the information from it to build ansimOptions
Object.Additional context
I mostly noted that things because i tried to Import an "normal" JSON instead of the CLI JSON, which resulted in the CLI crashing. at first i was not confident enough to say thats maybe a Layer 8 problem, but after checking basic differences of the JSON's and the code of the CLI, i noticed that these both exports are different, if not completly.
I would try to help you there, but im not that into deep into that project and don't currently know what the do's and don'ts are (specially at frontend side) so i created this ticket instead of an PR. Maybe this is even something that wont be fixed for WotLk but implemented in Cata
The text was updated successfully, but these errors were encountered: