Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Export CLI to Raid #4248

Open
Serverfrog opened this issue Apr 23, 2024 · 0 comments
Open

Add Export CLI to Raid #4248

Serverfrog opened this issue Apr 23, 2024 · 0 comments

Comments

@Serverfrog
Copy link

Is your feature request related to a problem? Please describe.
The Problem is the small difference between an Export JSON and Export CLI (as far as i could see).
It would be much easier to export an Raid for the CLI. If an JSONexport is used, the CLI wird hard crash, due to

if !rsr.SimOptions.IsTest {

(Given JSON is parsed into an RaidSimRequest but its missing the simOptions field, so that check will try to point something in nil)

Describe the solution you'd like
grafik
The Export -> CLI Option for the Raid Sim UI

Describe alternatives you've considered
Implement a small scripting myself wich removes the setting Object inside the JSON and uses the information from it to build an simOptions Object.

Additional context
I mostly noted that things because i tried to Import an "normal" JSON instead of the CLI JSON, which resulted in the CLI crashing. at first i was not confident enough to say thats maybe a Layer 8 problem, but after checking basic differences of the JSON's and the code of the CLI, i noticed that these both exports are different, if not completly.
I would try to help you there, but im not that into deep into that project and don't currently know what the do's and don'ts are (specially at frontend side) so i created this ticket instead of an PR. Maybe this is even something that wont be fixed for WotLk but implemented in Cata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant