Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iebaltab: layout updates #335

Open
luizaandrade opened this issue Apr 10, 2023 · 5 comments
Open

iebaltab: layout updates #335

luizaandrade opened this issue Apr 10, 2023 · 5 comments
Assignees
Milestone

Comments

@luizaandrade
Copy link
Member

luizaandrade commented Apr 10, 2023

I have a project at the Lab that needs to create a balance table with two panels. So I figured I'd implement this in iebaltab. My idea was to have a similar workflow as in estout by adding the following options:

anything else @kbjarkefur and @bbdaniels think should be included here?

@luizaandrade luizaandrade self-assigned this Apr 10, 2023
@luizaandrade luizaandrade added this to the v7.3 milestone Apr 10, 2023
@kbjarkefur
Copy link
Contributor

Would this only be for LaTeX? If not, then I think we should be specific what we want to do for LaTeX only and what we want to do for Excel and browse.

@kbjarkefur
Copy link
Contributor

I have a strong preference to no add separate options that specifically suppress certain stats. Instead, I think this is intended to be a part of the stats() option, see this issue: #293. A big part of my implementation in the re-write was to move away with the ad-hoc approach of separate options for specific layout options.

So that stats(desc(mean/se)) would be how you configure what is currently the default (happy to discuss whether that should be the default), and to drop the SE below mean you would do stats(desc(mean)).

@luizaandrade
Copy link
Member Author

Yes, this would be only for LaTeX. I agree on the stats() option. I don't think the suggested option from #147 should be the default. If this is already implemented as stats(desc(mean)), I think we can mark that issue as solved.

@kbjarkefur
Copy link
Contributor

I limited the scope of my big re-write to gather all already existing separate stats display options into stats(), but I did not add any new functionality to it. I had to limit the scope somehow to ever get that version out the door.

So instead of the stdev option you can now do stats(desc(sd)), but just as before the only option you have is to change what is displayed on the second row, not changing that there is no second row or that it is empty.

I think the solution is to allow users to set one or many stats in all of stats(desc() pair() f() feq()) and then the tables adjust to have as many rows needed for each of them. I have more thinking on the syntax for setting multiple options, but we should probably discuss that in the issue for that option.

@bbdaniels
Copy link
Contributor

I like this solution -- I should certainly be able to request stats( [...] pair(beta f p))!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants