fix: resolve incorrect deprecation location

Author: owenvoke

src/Collector.php

@@ -4,7 +4,6 @@
 
 namespace Worksome\PestGraphqlCoverage;
 
-use GraphQL\Language\AST\DirectiveNode;
 use Nuwave\Lighthouse\Schema\Values\FieldValue;
 
 class Collector
@@ -35,20 +34,13 @@ public static function parseResult(): array
 
     public static function addResult(FieldValue $fieldValue): void
     {
-        if (Config::shouldIgnoreDeprecatedFields() && self::isFieldDeprecated($fieldValue)) {
-            return;
-        }
+        $fieldName = sprintf('%s.%s', $fieldValue->getParentName(), $fieldValue->getFieldName());
 
         $filePath = self::filePath();
         $stream = fopen($filePath, 'a');
         assert(is_resource($stream));
 
-        fwrite($stream, sprintf(
-            '%s.%s%s',
-            $fieldValue->getParentName(),
-            $fieldValue->getFieldName(),
-            PHP_EOL
-        ));
+        fwrite($stream, $fieldName . PHP_EOL);
 
         fclose($stream);
     }
@@ -61,16 +53,4 @@ public static function filePath(): string
             'gql-coverage.php',
         ]);
     }
-
-    private static function isFieldDeprecated(FieldValue $fieldValue): bool
-    {
-        foreach ($fieldValue->getField()->directives as $directive) {
-            /** @var DirectiveNode $directive */
-            if ($directive->name->value === 'deprecated') {
-                return true;
-            }
-        }
-
-        return false;
-    }
 }

src/Config.php

@@ -9,6 +9,9 @@ final class Config
     /** @var list<string> */
     private static array $ignoredNodes = [];
 
+    /** @var list<string> */
+    private static array $deprecatedFields = [];
+
     private static bool $ignorePaginatorInfo = false;
 
     private static bool $ignoreDeprecatedFields = false;
@@ -52,6 +55,7 @@ public static function ignoredNodes(): array
     {
         return [
             ...self::$ignoredNodes,
+            ...self::$deprecatedFields,
             ...self::getPaginatorInfoNodes(),
         ];
     }
@@ -62,6 +66,12 @@ public static function shouldIgnoreDeprecatedFields(): bool
         return self::$ignoreDeprecatedFields;
     }
 
+    /** @internal */
+    public static function addDeprecatedField(string $deprecatedField): void
+    {
+        self::$deprecatedFields[] = $deprecatedField;
+    }
+
     /** @return list<string> */
     private static function getPaginatorInfoNodes(): array
     {

src/Plugin.php

@@ -4,6 +4,7 @@
 
 namespace Worksome\PestGraphqlCoverage;
 
+use GraphQL\Language\AST\DirectiveNode;
 use GraphQL\Language\AST\FieldDefinitionNode;
 use GraphQL\Language\AST\InterfaceTypeDefinitionNode;
 use GraphQL\Language\AST\NodeKind;
@@ -25,6 +26,8 @@ class Plugin implements AddsOutput, HandlesArguments
 
     private const SERVER_VARIABLE_NAME = 'GQL_COVERAGE_ENABLED';
 
+    private int $numberOfDeprecatedFields = 0;
+
     public int $maxUntestedFieldsCount = 10;
 
     public string $schemaCommand = 'php artisan lighthouse:print-schema';
@@ -173,6 +176,10 @@ public function addOutput(int $exitCode): int
 
         $style->writeln("GraphQL coverage:  $percentage% ($totalTestedNodes/$totalNodes fields)");
 
+        if (Config::shouldIgnoreDeprecatedFields() && $this->numberOfDeprecatedFields > 0) {
+            $style->writeln($this->numberOfDeprecatedFields . ' deprecated fields were ignored.');
+        }
+
         if ($untested !== []) {
             $style->newLine();
             $style->writeln("Untested fields (max. {$this->maxUntestedFieldsCount}): ");
@@ -215,10 +222,32 @@ private function collectAllNodesFromSchema(): array
                     return;
                 }
 
+                if (Config::shouldIgnoreDeprecatedFields() && self::isFieldDeprecated($node)) {
+                    Config::addDeprecatedField(
+                        sprintf('%s.%s', $parentType->name->value, $node->name->value)
+                    );
+
+                    $this->numberOfDeprecatedFields++;
+
+                    return;
+                }
+
                 $nodes[$parentType->name->value][$node->name->value] = true;
             },
         ]);
 
         return $nodes;
     }
+
+    private static function isFieldDeprecated(FieldDefinitionNode $node): bool
+    {
+        foreach ($node->directives as $directive) {
+            /** @var DirectiveNode $directive */
+            if ($directive->name->value === 'deprecated') {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }