From cd9c58915c401336a381dc7813916671c101df4a Mon Sep 17 00:00:00 2001 From: Zeeshan Asghar Date: Tue, 15 Mar 2016 15:19:23 +0500 Subject: [PATCH] squid:S1186 Methods should not be empty --- .../tourguide/FrameLayoutWithHole.java | 8 ++- .../java/tourguide/tourguide/TourGuide.java | 52 ++++++++++++++----- 2 files changed, 45 insertions(+), 15 deletions(-) diff --git a/tourguide/src/main/java/tourguide/tourguide/FrameLayoutWithHole.java b/tourguide/src/main/java/tourguide/tourguide/FrameLayoutWithHole.java index 6141d30..31ee9ac 100644 --- a/tourguide/src/main/java/tourguide/tourguide/FrameLayoutWithHole.java +++ b/tourguide/src/main/java/tourguide/tourguide/FrameLayoutWithHole.java @@ -153,8 +153,12 @@ private void performOverlayExitAnimation(){ mCleanUpLock = true; Log.d("tourguide","Overlay exit animation listener is overwritten..."); mOverlay.mExitAnimation.setAnimationListener(new Animation.AnimationListener() { - @Override public void onAnimationStart(Animation animation) {} - @Override public void onAnimationRepeat(Animation animation) {} + @Override public void onAnimationStart(Animation animation) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationRepeat(Animation animation) { + throw new UnsupportedOperationException(); + } @Override public void onAnimationEnd(Animation animation) { ((ViewGroup) _pointerToFrameLayout.getParent()).removeView(_pointerToFrameLayout); diff --git a/tourguide/src/main/java/tourguide/tourguide/TourGuide.java b/tourguide/src/main/java/tourguide/tourguide/TourGuide.java index ee696ef..2fea8ab 100644 --- a/tourguide/src/main/java/tourguide/tourguide/TourGuide.java +++ b/tourguide/src/main/java/tourguide/tourguide/TourGuide.java @@ -265,7 +265,9 @@ else if (mOverlay != null && mOverlay.mDisableClick) { frameLayoutWithHole.setViewHole(mHighlightedView); frameLayoutWithHole.setSoundEffectsEnabled(false); frameLayoutWithHole.setOnClickListener(new View.OnClickListener() { - @Override public void onClick(View v) {} // do nothing, disabled. + @Override public void onClick(View v) { + throw new UnsupportedOperationException(); + } // do nothing, disabled. }); } } @@ -459,9 +461,15 @@ private void performAnimationOn(final View view){ final AnimatorSet animatorSet = new AnimatorSet(); final AnimatorSet animatorSet2 = new AnimatorSet(); Animator.AnimatorListener lis1 = new Animator.AnimatorListener() { - @Override public void onAnimationStart(Animator animator) {} - @Override public void onAnimationCancel(Animator animator) {} - @Override public void onAnimationRepeat(Animator animator) {} + @Override public void onAnimationStart(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationCancel(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationRepeat(Animator animator) { + throw new UnsupportedOperationException(); + } @Override public void onAnimationEnd(Animator animator) { view.setScaleX(1f); @@ -471,9 +479,15 @@ public void onAnimationEnd(Animator animator) { } }; Animator.AnimatorListener lis2 = new Animator.AnimatorListener() { - @Override public void onAnimationStart(Animator animator) {} - @Override public void onAnimationCancel(Animator animator) {} - @Override public void onAnimationRepeat(Animator animator) {} + @Override public void onAnimationStart(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationCancel(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationRepeat(Animator animator) { + throw new UnsupportedOperationException(); + } @Override public void onAnimationEnd(Animator animator) { view.setScaleX(1f); @@ -536,9 +550,15 @@ public void onAnimationEnd(Animator animator) { final AnimatorSet animatorSet = new AnimatorSet(); final AnimatorSet animatorSet2 = new AnimatorSet(); Animator.AnimatorListener lis1 = new Animator.AnimatorListener() { - @Override public void onAnimationStart(Animator animator) {} - @Override public void onAnimationCancel(Animator animator) {} - @Override public void onAnimationRepeat(Animator animator) {} + @Override public void onAnimationStart(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationCancel(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationRepeat(Animator animator) { + throw new UnsupportedOperationException(); + } @Override public void onAnimationEnd(Animator animator) { view.setScaleX(1f); @@ -548,9 +568,15 @@ public void onAnimationEnd(Animator animator) { } }; Animator.AnimatorListener lis2 = new Animator.AnimatorListener() { - @Override public void onAnimationStart(Animator animator) {} - @Override public void onAnimationCancel(Animator animator) {} - @Override public void onAnimationRepeat(Animator animator) {} + @Override public void onAnimationStart(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationCancel(Animator animator) { + throw new UnsupportedOperationException(); + } + @Override public void onAnimationRepeat(Animator animator) { + throw new UnsupportedOperationException(); + } @Override public void onAnimationEnd(Animator animator) { view.setScaleX(1f);