Introduce a couple of ios/app_store values for some Locales as a starting point + enable missing corresponding specs

Author: AliSoftware

lib/fastlane/plugin/wpmreleasetoolkit/models/locales.rb

@@ -23,23 +23,23 @@ class Locales
       Locale.new(glotpress: 'en-gb', android: 'en-rGB', google_play: 'en-US'),
       Locale.new(glotpress: 'es',    android: 'es',     google_play: 'es-ES'),
       Locale.new(glotpress: 'fr-ca', android: 'fr-rCA', google_play: 'fr-CA'),
-      Locale.new(glotpress: 'fr',    android: 'fr',     google_play: 'fr-FR'),
+      Locale.new(glotpress: 'fr',    android: 'fr',     google_play: 'fr-FR', ios: 'fr-FR', app_store: 'fr-FR'),
       Locale.new(glotpress: 'he',    android: 'he',     google_play: 'iw-IL'),
       Locale.new(glotpress: 'id',    android: 'id',     google_play: 'id'),
       Locale.new(glotpress: 'it',    android: 'it',     google_play: 'it-IT'),
       Locale.new(glotpress: 'ja',    android: 'ja',     google_play: 'ja-JP'),
       Locale.new(glotpress: 'ko',    android: 'ko',     google_play: 'ko-KR'),
       Locale.new(glotpress: 'nl',    android: 'nl',     google_play: 'nl-NL'),
       Locale.new(glotpress: 'pl',    android: 'pl',     google_play: 'pl-PL'),
-      Locale.new(glotpress: 'pt-br', android: 'pt-rBR', google_play: 'pt-BR'),
+      Locale.new(glotpress: 'pt-br', android: 'pt-rBR', google_play: 'pt-BR', ios: 'pt-BR', app_store: 'pt-BR'),
       Locale.new(glotpress: 'ru',    android: 'ru',     google_play: 'ru-RU'),
       Locale.new(glotpress: 'sr',    android: 'sr',     google_play: 'sr'),
       Locale.new(glotpress: 'sv',    android: 'sv',     google_play: 'sv-SE'),
       Locale.new(glotpress: 'th',    android: 'th',     google_play: 'th'),
       Locale.new(glotpress: 'tr',    android: 'tr',     google_play: 'tr-TR'),
       Locale.new(glotpress: 'vi',    android: 'vi',     google_play: 'vi'),
-      Locale.new(glotpress: 'zh-cn', android: 'zh-rCN', google_play: 'zh-CN'),
-      Locale.new(glotpress: 'zh-tw', android: 'zh-rTW', google_play: 'zh-TW'),
+      Locale.new(glotpress: 'zh-cn', android: 'zh-rCN', google_play: 'zh-CN', ios: 'zh-Hans', app_store: 'zh-Hans'),
+      Locale.new(glotpress: 'zh-tw', android: 'zh-rTW', google_play: 'zh-TW', ios: 'zh-Hant', app_store: 'zh-Hant'),
       Locale.new(glotpress: 'az',    android: 'az'),
       Locale.new(glotpress: 'el',    android: 'el'),
       Locale.new(glotpress: 'es-mx', android: 'es-rMX'),

spec/locale_spec.rb

@@ -15,6 +15,6 @@
 
   it 'can convert a Locale to a hash' do
     h = described_class['fr'].to_h
-    expect(h).to eq({ glotpress: 'fr', android: 'fr', google_play: 'fr-FR', ios: nil, app_store: nil })
+    expect(h).to eq({ glotpress: 'fr', android: 'fr', google_play: 'fr-FR', ios: 'fr-FR', app_store: 'fr-FR' })
   end
 end

spec/locales_spec.rb

@@ -3,6 +3,7 @@
 describe Fastlane::Locales do
   shared_examples 'from_xxx' do |key, fr_code, pt_code|
     let(:method_sym) { "from_#{key}".to_sym }
+
     it 'can find a locale from a single code' do
       fr_locale = described_class.send(method_sym, fr_code)
       expect(fr_locale).to be_instance_of(Fastlane::Locale)
@@ -41,7 +42,13 @@
     include_examples 'from_xxx', :google_play, 'fr-FR', 'pt-BR'
   end
 
-  # @TODO: from_ios, from_app_store
+  describe 'from_ios' do
+    include_examples 'from_xxx', :ios, 'fr-FR', 'pt-BR'
+  end
+
+  describe 'from_app_store' do
+    include_examples 'from_xxx', :app_store, 'fr-FR', 'pt-BR'
+  end
 
   describe 'subscript [] operator' do
     it 'returns an Array<Locale> even if a single one was passed' do