Merge pull request #3047 from wordpress-mobile/issue/3046-atomic-cookie-numberformatexception

[FluxC] Catch NumberFormatException in PrivateAtomicCookie

Author: nbradbury

fluxc/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/site/PrivateAtomicCookie.kt

@@ -33,13 +33,19 @@ class PrivateAtomicCookie
     }
 
     private fun isExpiringSoon(): Boolean {
-        if (!exists()) {
-            return true
+        return if (!exists()) {
+            true
+        } else {
+            try {
+                val cookieExpiration: Long = cookie!!.expires.toLong()
+                val currentTime = (System.currentTimeMillis() / MILLIS)
+                currentTime + COOKIE_EXPIRATION_THRESHOLD >= cookieExpiration
+            } catch (e: NumberFormatException) {
+                // we ran into a situation where cookie!!.expires contained "false" resulting
+                // in an exception attempting to convert it to a long
+                false
+            }
         }
-        val cookieExpiration: Long = cookie!!.expires.toLong()
-        val currentTime = (System.currentTimeMillis() / MILLIS)
-
-        return currentTime + COOKIE_EXPIRATION_THRESHOLD >= cookieExpiration
     }
 
     fun exists(): Boolean {