Merge remote-tracking branch 'origin/trunk' into issue/11794-fetch-single-order-sync

Author: Alejo

.buildkite/schedules/dependency-analysis.yml

@@ -0,0 +1,18 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+---
+
+agents:
+  queue: "android"
+
+steps:
+  - label: "dependency analysis"
+    command: |
+      echo "--- 📊 Analyzing"
+      cp gradle.properties-example gradle.properties && cp -a example/properties-example/ example/properties/
+      ./gradlew buildHealth
+    plugins: [$CI_TOOLKIT]
+    artifact_paths:
+      - "build/reports/dependency-analysis/build-health-report.*"
+    notify:
+      - slack: "#android-core-notifs"
+        if: build.state == "failed"

build.gradle

@@ -1,3 +1,5 @@
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
+
 plugins {
     // Those declarations are just a workaround for a false-positive Kotlin Gradle Plugin warning
     // https://youtrack.jetbrains.com/issue/KT-46200
@@ -8,6 +10,7 @@ plugins {
     alias(sharedLibs.plugins.kotlin.detekt).apply(false)
     alias(sharedLibs.plugins.kotlin.jvm).apply(false)
     alias(sharedLibs.plugins.kotlin.kapt).apply(false)
+    alias(sharedLibs.plugins.dependency.analysis)
 
     alias(sharedLibs.plugins.automattic.configure)
 }
@@ -57,6 +60,12 @@ allprojects {
         parallel = true
         debug = false
     }
+
+    tasks.withType(KotlinCompile).configureEach {
+        kotlinOptions {
+            jvmTarget = JavaVersion.VERSION_1_8
+        }
+    }
 }
 
 ext {

config/detekt/detekt.yml

@@ -15,10 +15,6 @@ coroutines:
   GlobalCoroutineUsage:
     active: true
 
-potential-bugs:
-  MissingWhenCase:
-    allowElseExpression: false
-
 style:
   DataClassShouldBeImmutable:
     active: true

example/src/androidTest/java/org/wordpress/android/fluxc/release/utils/ListStoreConnectedTestHelper.kt

@@ -25,7 +25,7 @@ internal class ListStoreConnectedTestHelper(private val listStore: ListStore) {
      *
      * It uses a default [Lifecycle] instance which will NOT be destroyed throughout the test.
      */
-    fun <LIST_DESCRIPTOR : ListDescriptor, ITEM_IDENTIFIER, LIST_ITEM> getList(
+    fun <LIST_DESCRIPTOR : ListDescriptor, ITEM_IDENTIFIER, LIST_ITEM : Any> getList(
         listDescriptor: LIST_DESCRIPTOR,
         dataSource: ListItemDataSourceInterface<LIST_DESCRIPTOR, ITEM_IDENTIFIER, LIST_ITEM>,
         lifecycle: Lifecycle = SimpleTestLifecycle().lifecycle

example/src/main/java/org/wordpress/android/fluxc/example/MainFragment.kt

@@ -305,6 +305,8 @@ class MainFragment : Fragment() {
                 AuthenticationErrorType.UNSUPPORTED_RESPONSE_TYPE,
                 AuthenticationErrorType.EMAIL_LOGIN_NOT_ALLOWED,
                 AuthenticationErrorType.GENERIC_ERROR,
+                AuthenticationErrorType.NEEDS_SECURITY_KEY -> Unit // Do nothing
+                AuthenticationErrorType.WEBAUTHN_FAILED -> Unit // Do nothing
                 null -> {
                     // Show Toast "Network Error"?
                 }

example/src/main/java/org/wordpress/android/fluxc/example/ReactNativeFragment.kt

@@ -83,6 +83,7 @@ class ReactNativeFragment : Fragment() {
                         AppLog.i(AppLog.T.API, "Request result: ${response.result}")
                     }
                     is Error -> prependToLog("Request to '$path' failed: ${response.error.message}")
+                    null -> Unit // Do nothing
                 }
             }
         }

example/src/main/java/org/wordpress/android/fluxc/example/di/AppConfigModule.java

@@ -15,6 +15,8 @@
 
 import java.lang.reflect.Field;
 
+import javax.inject.Singleton;
+
 import dagger.Module;
 import dagger.Provides;
 
@@ -41,6 +43,7 @@ public AppSecrets provideAppSecrets() {
     }
 
     @Provides
+    @Singleton
     public UserAgent provideUserAgent(Context appContext) {
         return new UserAgent(appContext, "fluxc-example-android");
     }

example/src/main/java/org/wordpress/android/fluxc/example/ui/stats/WooRevenueStatsFragment.kt

@@ -305,6 +305,9 @@ class WooRevenueStatsFragment : StoreSelectingFragment() {
             WCStatsAction.FETCH_REVENUE_STATS_AVAILABILITY -> {
                 prependToLog("Revenue stats available for site ${site?.name}: ${event.availability}")
             }
+            WCStatsAction.FETCH_NEW_VISITOR_STATS -> Unit // Do nothing
+            WCStatsAction.FETCHED_REVENUE_STATS_AVAILABILITY -> Unit // Do nothing
+            null -> Unit // Do nothing
         }
     }
 
@@ -343,6 +346,9 @@ class WooRevenueStatsFragment : StoreSelectingFragment() {
                     }
                 }
             }
+            WCStatsAction.FETCH_REVENUE_STATS_AVAILABILITY -> Unit // Do nothing
+            WCStatsAction.FETCHED_REVENUE_STATS_AVAILABILITY -> Unit // Do nothing
+            null -> Unit // Do nothing
         }
     }
 }

example/src/main/java/org/wordpress/android/fluxc/example/ui/wooadmin/WooAdminFragment.kt

@@ -5,7 +5,6 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.lifecycle.lifecycleScope
-import com.google.gson.Gson
 import kotlinx.coroutines.launch
 import org.wordpress.android.fluxc.example.databinding.FragmentWooAdminBinding
 import org.wordpress.android.fluxc.example.prependToLog
@@ -16,7 +15,6 @@ import javax.inject.Inject
 
 class WooAdminFragment : StoreSelectingFragment() {
     @Inject internal lateinit var wooAdminStore: WooAdminStore
-    private val gson = Gson()
 
     override fun onCreateView(
         inflater: LayoutInflater,

example/src/main/java/org/wordpress/android/fluxc/example/utils/ViewGroupExt.kt

@@ -11,5 +11,7 @@ fun ViewGroup.toggleSiteDependentButtons(enabled: Boolean = true) =
 
 fun ViewGroup.childViewsAsSequence(): Sequence<View> =
         mutableListOf<View>().apply {
-            (0 until childCount).forEach { add(getChildAt(it)) }
+                for (it in 0 until childCount) {
+                        add(getChildAt(it))
+                }
         }.asSequence()