[MVC 구현 - 3단계] 매튜(김재연) 미션 제출합니다. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyena0608
requested changes
Sep 25, 2023
| @Override | ||
| public String getViewName() { | ||
| return ""; | ||
| public void render( |
There was a problem hiding this comment.
텍스트를 전송할 때 OutputStream 대신 PrinterWriter를 사용해보시는거는 어떤가요?
| @Override | ||
| public HandlerExecution getHandler(final HttpServletRequest request) { | ||
| public Object getHandler(HttpServletRequest request) { |
There was a problem hiding this comment.
HandlerExecution이 아닌 Object를 반환하니 이후에 다른 객체의 타입을 반환해도 처리해줄 수 있네요! 👍👍
AnnotationHandlerMappingTest도 수정해주시면 될 거 같아요!
| import jakarta.servlet.http.HttpServletResponse; | ||
| import webmvc.org.springframework.web.servlet.ModelAndView; | ||
|
|
||
| public interface HandlerAdapter { |
There was a problem hiding this comment.
HandlerAdapter를 구현해주셨군요!
고생하셨어요 매튜매튜~
|
헤이나 헤이나! 말씀해주신 부분들 다 수정해봤어요! 이번에도 잘 부탁드려요~~!! 알러뷰 |
hyena0608
requested changes
Sep 26, 2023
Comment on lines
20
to
22
| response.setContentType(MediaType.APPLICATION_JSON_UTF8_VALUE); | ||
| String responseBody = objectMapper.writeValueAsString(model); | ||
| response.getWriter().write(responseBody); |
There was a problem hiding this comment.
✨ 매튜매튜 ✨
ObjectMapper로 Model에 들어있는 값인 user를 json으로 파싱하지 못했어요!
http://localhost:8080/api/user?account=gugu로 접속시 아래와 같이 나오는데
아래와 같이 나오면 좋을거 같네요!
(그리고 요구사항 중에 모델에 값이 하나 일 때는 값을 바로 반환해달라는 요구가 있었어요~
오늘 강의에서도 얘기 나온 부분이네요 👍)
|
헤이나 리뷰 반영했어요오오오오 잘 부탁드립니다~! |
hyena0608
approved these changes
Sep 27, 2023
Comment on lines
+25
to
+33
| private String modelToJson(final Map<String, ?> model) throws Exception { | ||
| if (model.size() == 1) { | ||
| Object next = model.values() | ||
| .iterator() | ||
| .next(); | ||
| return objectMapper.writeValueAsString(next); | ||
| } | ||
|
|
||
| return objectMapper.writeValueAsString(model); |
There was a problem hiding this comment.
굿굿 매튜매튜!!! 다른 미션도 바쁘실텐데 고생하셨어요! 👍✨👍✨👍✨👍✨👍✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
헤이나아아아아~~~!!
2단계 머지하면서 주신 코멘트들도 적용해봤어요!
아쉬운 것은, 힘들게
Adapter도입했는데Legacy Code를 지우라는 요구사항이 있더군요..눈물을 머금고 지웠습니다.
그러면서
ManualHandlerAdapter,ManualHandlerMapping도 지웠어요! 쓰지 않는 거대한 코드를 남겨 놓는다면 코드를 읽는 사람으로 하여금 혼란을 불러일으킬 수 있을 것 같아서요!이번 리뷰도 잘 부탁드려요 알러뷰 헤이나~! 주말에 리뷰 너무 고마워요~~~❤️