[MVC 구현하기 - 3단계] 블랙캣(송우석) 미션 제출합니다. (#591)

* refactor: Jsp 렌더링을 JspView 객체로 위임

* refactor: 레거시 MVC 삭제 및 어노테이션 MVC로 변경

* feat: JSON 문자열을 객체로 직렬화 하는 기능 구현

* feat: 컨트롤러 메서드에서 세션, @RequestParam, @RequestBody 를 받을 수 있는 기능 구현

* feat: JSON 반환 기능 구현

* refactor: 컨트롤러 메서드 파라미터 변경

* refactor: app 모듈에서 mvc 프레임워크 모듈로 이동

* refactor: 코드 정렬

* refactor: DispatcherServletInitializer app 모듈로 이동

* refactor: 어노테이션 매핑 핸들러의 getHandler 반환타입 변경

* refactor: 로그인 뷰 - 로그인 요청 컨틀롤러 통합

* refactor: ObjectWriter, ObjectReader 로 static 선언

* remove: 사용하지 않는 메서드 제거

Author: Songusika

app/src/main/java/com/techcourse/Application.java

@@ -1,10 +1,9 @@
 package com.techcourse;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.io.IOException;
 import java.util.stream.Stream;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class Application {
 

app/src/main/java/com/techcourse/DispatcherServletInitializer.java

@@ -24,11 +24,9 @@ public class DispatcherServletInitializer implements WebApplicationInitializer {
     @Override
     public void onStartup(final ServletContext servletContext) {
         final HandlerMappings handlerMappings = new HandlerMappings(List.of(
-                new ManualHandlerMapping(),
                 new AnnotationHandlerMapping("com.techcourse.controller")
         ));
         final HandlerAdapters handlerAdapters = new HandlerAdapters(List.of(
-                new ManualHandlerAdapter(),
                 new AnnotationHandlerAdapter()
         ));
         final var dispatcherServlet = new DispatcherServlet(handlerMappings, handlerAdapters);

app/src/main/java/com/techcourse/ManualHandlerAdapter.java

@@ -1,14 +1,13 @@
 package com.techcourse;
 
+import java.io.File;
 import org.apache.catalina.Context;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.connector.Connector;
 import org.apache.catalina.core.StandardContext;
 import org.apache.catalina.startup.Tomcat;
 import org.apache.tomcat.util.scan.StandardJarScanner;
 
-import java.io.File;
-
 public class TomcatStarter {
 
     public static final String WEBAPP_DIR_LOCATION = "app/src/main/webapp/";

app/src/main/java/com/techcourse/ManualHandlerMapping.java

@@ -0,0 +1,16 @@
+package com.techcourse.controller;
+
+import context.org.springframework.stereotype.Controller;
+import web.org.springframework.web.bind.annotation.RequestMapping;
+import web.org.springframework.web.bind.annotation.RequestMethod;
+import webmvc.org.springframework.web.servlet.ModelAndView;
+import webmvc.org.springframework.web.servlet.view.JspView;
+
+@Controller
+public class IndexController {
+
+    @RequestMapping(value = "/", method = RequestMethod.GET)
+    public ModelAndView index() {
+        return new ModelAndView(new JspView("/index.jsp"));
+    }
+}

app/src/main/java/com/techcourse/TomcatStarter.java

@@ -2,33 +2,53 @@
 
 import com.techcourse.domain.User;
 import com.techcourse.repository.InMemoryUserRepository;
-import jakarta.servlet.http.HttpServletRequest;
-import jakarta.servlet.http.HttpServletResponse;
-import webmvc.org.springframework.web.servlet.mvc.asis.Controller;
+import context.org.springframework.stereotype.Controller;
+import jakarta.servlet.http.HttpSession;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import web.org.springframework.web.bind.annotation.RequestMapping;
+import web.org.springframework.web.bind.annotation.RequestMethod;
+import web.org.springframework.web.bind.annotation.RequestParam;
+import webmvc.org.springframework.web.servlet.ModelAndView;
+import webmvc.org.springframework.web.servlet.view.JspView;
 
-public class LoginController implements Controller {
+@Controller
+public class LoginController {
 
     private static final Logger log = LoggerFactory.getLogger(LoginController.class);
 
-    @Override
-    public String execute(final HttpServletRequest req, final HttpServletResponse res) throws Exception {
-        if (UserSession.isLoggedIn(req.getSession())) {
-            return "redirect:/index.jsp";
+    @RequestMapping(value = "/login/view", method = RequestMethod.GET)
+    public ModelAndView loginView(final HttpSession session) {
+        return UserSession.getUserFrom(session)
+                .map(user -> {
+                    log.info("logged in {}", user.getAccount());
+                    return "redirect:/index.jsp";
+                })
+                .map(it -> new ModelAndView(new JspView(it)))
+                .orElse(new ModelAndView(new JspView("/login.jsp")));
+    }
+
+    @RequestMapping(value = "/login", method = RequestMethod.POST)
+    public ModelAndView login(
+            final HttpSession session,
+            @RequestParam(value = "account") final String account,
+            @RequestParam("password") final String password
+    ) {
+        if (UserSession.isLoggedIn(session)) {
+            return new ModelAndView(new JspView("redirect:/index.jsp"));
         }
 
-        return InMemoryUserRepository.findByAccount(req.getParameter("account"))
+        return InMemoryUserRepository.findByAccount(account)
                 .map(user -> {
                     log.info("User : {}", user);
-                    return login(req, user);
+                    return login(user, password, session);
                 })
-                .orElse("redirect:/401.jsp");
+                .map(it -> new ModelAndView(new JspView(it)))
+                .orElse(new ModelAndView(new JspView("redirect:/401.jsp")));
     }
 
-    private String login(final HttpServletRequest request, final User user) {
-        if (user.checkPassword(request.getParameter("password"))) {
-            final var session = request.getSession();
+    private String login(final User user, final String password, final HttpSession session) {
+        if (user.checkPassword(password)) {
             session.setAttribute(UserSession.SESSION_KEY, user);
             return "redirect:/index.jsp";
         }

app/src/main/java/com/techcourse/controller/IndexController.java

@@ -1,15 +1,18 @@
 package com.techcourse.controller;
 
-import jakarta.servlet.http.HttpServletRequest;
-import jakarta.servlet.http.HttpServletResponse;
-import webmvc.org.springframework.web.servlet.mvc.asis.Controller;
+import context.org.springframework.stereotype.Controller;
+import jakarta.servlet.http.HttpSession;
+import web.org.springframework.web.bind.annotation.RequestMapping;
+import web.org.springframework.web.bind.annotation.RequestMethod;
+import webmvc.org.springframework.web.servlet.ModelAndView;
+import webmvc.org.springframework.web.servlet.view.JspView;
 
-public class LogoutController implements Controller {
+@Controller
+public class LogoutController {
 
-    @Override
-    public String execute(final HttpServletRequest req, final HttpServletResponse res) throws Exception {
-        final var session = req.getSession();
+    @RequestMapping(value = "/logout", method = RequestMethod.GET)
+    public ModelAndView logout(final HttpSession session) {
         session.removeAttribute(UserSession.SESSION_KEY);
-        return "redirect:/";
+        return new ModelAndView(new JspView("redirect:/"));
     }
 }

app/src/main/java/com/techcourse/controller/LoginController.java

@@ -1,10 +1,10 @@
 package com.techcourse.controller;
 
 import com.techcourse.domain.User;
+import com.techcourse.dto.RegisterRequest;
 import com.techcourse.repository.InMemoryUserRepository;
 import context.org.springframework.stereotype.Controller;
-import jakarta.servlet.http.HttpServletRequest;
-import jakarta.servlet.http.HttpServletResponse;
+import web.org.springframework.web.bind.annotation.RequestBody;
 import web.org.springframework.web.bind.annotation.RequestMapping;
 import web.org.springframework.web.bind.annotation.RequestMethod;
 import webmvc.org.springframework.web.servlet.ModelAndView;
@@ -14,18 +14,18 @@
 public class RegisterController {
 
     @RequestMapping(value = "/register", method = RequestMethod.POST)
-    public ModelAndView save(HttpServletRequest req, HttpServletResponse res) {
+    public ModelAndView save(@RequestBody final RegisterRequest registerRequest) {
         final var user = new User(2,
-                req.getParameter("account"),
-                req.getParameter("password"),
-                req.getParameter("email"));
+                registerRequest.getAccount(),
+                registerRequest.getPassword(),
+                registerRequest.getEmail());
         InMemoryUserRepository.save(user);
 
         return new ModelAndView(new JspView("redirect:/index.jsp"));
     }
 
-    @RequestMapping(value = "/register", method = RequestMethod.GET)
-    public ModelAndView show(HttpServletRequest req, HttpServletResponse res) {
+    @RequestMapping(value = "/register/view", method = RequestMethod.GET)
+    public ModelAndView show() {
         return new ModelAndView(new JspView("/register.jsp"));
     }
 }