Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review if we can remove duplicated IapMobilePayApiProviders #8148

Open
JorgeMucientes opened this issue Jan 9, 2023 · 1 comment
Open

Review if we can remove duplicated IapMobilePayApiProviders #8148

JorgeMucientes opened this issue Jan 9, 2023 · 1 comment
Assignees
@JorgeMucientes
Labels
feature: in-app purchase feature: store creation Store creation flow

Comments

@JorgeMucientes
Copy link
Contributor

Currently IAPShowcaseMobilePayAPIProvider and IapMobilePayApiProvider are identical and most likely they will remain identical for the first version of IAP used for store creation.
Double check if we can remove one of them and put the other in the appropriate file.
@JorgeMucientes JorgeMucientes self-assigned this Jan 9, 2023
@peril-woocommerce
Copy link

Fails
🚫 Please add a type label to this issue. e.g. 'type: enhancement'

Generated by 🚫 dangerJS

@JorgeMucientes JorgeMucientes mentioned this issue Jan 9, 2023
Merged
@JorgeMucientes JorgeMucientes mentioned this issue Jan 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorgeMucientes JorgeMucientes

Labels
feature: in-app purchase feature: store creation Store creation flow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JorgeMucientes