Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS][Cash & Receipts] Implement UI changes #13177

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

[Woo POS][Cash & Receipts] Implement UI changes #13177

wants to merge 3 commits into from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 20, 2024 •
edited
Loading

Closes: #13176

Description

  • Changes the color of the change due text on the cash payment screen
  • Changes the text on the payment success screen depending on the cash/card flow

Testing information

  • Do both card and cash flows
  • Notice the color of the change due text on the cash payment screen
  • Notice the text on the payment success screen depending on the cash/card flow

The tests that have been performed

Aboce

Images/gif

12-20--14-31.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Dec 20, 2024 that may be closed by this pull request
[Woo POS][Cash & Receipts] Implement UI changes #13176
Open
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 20, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6f83a07
Direct Downloadwoocommerce-wear-prototype-build-pr13177-6f83a07.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 20, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6f83a07
Direct Downloadwoocommerce-prototype-build-pr13177-6f83a07.apk

@kidinov kidinov requested a review from AnirudhBhat December 20, 2024 14:27
@kidinov kidinov added the feature: point of sale POS project label Dec 20, 2024
@kidinov kidinov added this to the 21.4 milestone Dec 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 40.55%. Comparing base (28349ee) to head (6f83a07).

Files with missing lines Patch % Lines
...oid/ui/woopos/home/totals/WooPosTotalsViewModel.kt 0.00% 7 Missing ⚠️
...erce/android/ui/woopos/home/WooPosHomeViewModel.kt 60.00% 2 Missing ⚠️
...oopos/home/WooPosHomeParentToChildCommunication.kt 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##              trunk   #13177   +/-   ##
=========================================
  Coverage     40.55%   40.55%           
  Complexity     6367     6367           
=========================================
  Files          1344     1344           
  Lines         77229    77228    -1     
  Branches      10597    10598    +1     
=========================================
+ Hits          31318    31321    +3     
+ Misses        43165    43161    -4     
  Partials       2746     2746

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnirudhBhat AnirudhBhat Awaiting requested review from AnirudhBhat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature: point of sale POS project
Projects
None yet
Milestone
21.4
Development

Successfully merging this pull request may close these issues.

[Woo POS][Cash & Receipts] Implement UI changes
3 participants
@kidinov @wpmobilebot @codecov-commenter