Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default values for Blaze ad preview when fetching suggestions fail #13075

Open
JorgeMucientes opened this issue Dec 5, 2024 · 1 comment
Open

Set default values for Blaze ad preview when fetching suggestions fail #13075

JorgeMucientes opened this issue Dec 5, 2024 · 1 comment
Labels
priority: medium Planned tasks usually belonging to ongoing projects type: enhancement A request for an enhancement.

Comments

@JorgeMucientes
Copy link
Contributor

JorgeMucientes commented Dec 5, 2024 •
edited
Loading

iOS counterpart: woocommerce/woocommerce-ios#14616

When Blaze API fails to load the suggestion we should avoid showing the ad preview empty and instead set some default values using the selected product data.

  • Use product name for ad title
  • Use product short description if available or Description for ad description.

The idea is to avoid this empty preview:
@JorgeMucientes JorgeMucientes added the type: enhancement A request for an enhancement. label Dec 5, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 5, 2024 •
edited
Loading

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

@JorgeMucientes JorgeMucientes added the priority: medium Planned tasks usually belonging to ongoing projects label Dec 5, 2024
@JorgeMucientes JorgeMucientes mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium Planned tasks usually belonging to ongoing projects type: enhancement A request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JorgeMucientes @dangermattic