Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken "View Certificate Button" block when changing language. #322

Open
aaronfc opened this issue Nov 11, 2022 · 0 comments
Open

Broken "View Certificate Button" block when changing language. #322

aaronfc opened this issue Nov 11, 2022 · 0 comments
Labels
[Type] Bug [Type] Good First Bug

Comments

@aaronfc
Copy link
Contributor

aaronfc commented Nov 11, 2022

There's a problem with the encoding in this Button Block. When you change the text from English to a non-latin word (e.g. Greek) everything breaks in the front-end.

Reported originally by @elninio7 here.
aaronfc referenced this issue Nov 11, 2022
@aaronfc
Add "View Certificate Button" block.
5f1c2a2 
Fixes #261

- Adding new `sensei-certificate/view-certificate` block.
- This block relies on existing method to generate the certificate link.
- Logic to generate the certificate link has been updated to:
  - Hide block if user didn't complete the course yet.
  - Get course_id from current course as fallback if GET is not set.
- Added `@wordpress/icon` dependency to set the "button" icon for the
  new block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug [Type] Good First Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronfc