Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to be able to customize the name that displays on the certificate #252

Open
donnapep opened this issue Nov 18, 2020 · 6 comments
Assignees
Labels
Hooks This change adds or modifies one or more hooks. [Pri] Normal [Type] Enhancement

Comments

@donnapep
Copy link
Contributor

Is your feature request related to a problem? Please describe

It's currently not possible to customize the display of the learner's name that appears on the certificate. It displays as First Name Last Name if both are specified, or otherwise uses the learner's display name.

Describe the solution you'd like

Add a filter so that the learner name can be customized on both the certificate template and the certificate.

@donnapep donnapep added [Type] Enhancement [Pri] Normal Hooks This change adds or modifies one or more hooks. [Status] Queued In the queue of issues to work on next. labels Nov 18, 2020
@yscik
Copy link
Contributor

yscik commented Jan 27, 2021

Could be worth merging #94 for this.

@cena
Copy link

cena commented Sep 1, 2021

Not sure if completely related, but user wants to

add [users'] full name when they finish the course, as our courses are free without any login or any profile

https://wordpress.org/support/topic/users-full-name-can-add-by-them-self-in-no-login-course/#post-14828344

@donnapep donnapep added this to the 2.2.3 milestone Nov 1, 2021
@m1r0
Copy link
Member

m1r0 commented Nov 16, 2021

I agree with @yscik. We should consider solving this in a more general way and not only for one data type. Also, this approach most likely will solve these issues: #285, #284, #134, #116, #103, #102, #93.

Thoughts?

cc @yscik @donnapep

@yscik
Copy link
Contributor

yscik commented Nov 16, 2021

Yeah let's do it! I looked at it briefly before and there were quite a few merge conflicts IIRC — maybe rebasing that branch onto master is easier since it'd be just one pass.
Also basically the whole thing is duplicated and exists at two places in the code, could be a good opportunity to clean it up :)

@donnapep
Copy link
Contributor Author

@m1r0 and I talked and he's planning to review #94, resolve conflicts and make any changes, if necessary.

@m1r0 m1r0 modified the milestones: 2.2.2, 2.3.0 Nov 26, 2021
@aaronfc aaronfc modified the milestones: 2.3.0, 2.4.0 Jul 11, 2022
@StefMattana
Copy link

StefMattana commented Aug 4, 2022

Somehow related to this, mentioned in 5417376-zen:

Although I have asked learners to sign in with the name they want on their certificate, they are all using their user name which is not their proper name. If there was a separate way to sign in as a learner only, that would help both the certificate and website user issues.

@gikaragia gikaragia removed the [Status] Queued In the queue of issues to work on next. label Dec 5, 2022
@m1r0 m1r0 removed this from the 2.4.0 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hooks This change adds or modifies one or more hooks. [Pri] Normal [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

7 participants