Merge branch 'refs/heads/update/actions-to-fail-with-exceptions' into add/notices-for-important-api-exceptions

Author: message-dimke

src/CommerceIntegration.php

@@ -128,6 +128,7 @@ public static function handle_create( $attempt = 0 ): array {
 	 * Handles Commerce Integration partner_metadata updates.
 	 *
 	 * @since 1.4.11
+	 * @throws PinterestApiException Pinterest API exception.
 	 * @return void
 	 */
 	public static function handle_sync() {
@@ -171,6 +172,7 @@ public static function handle_sync() {
 				),
 				'error'
 			);
+			throw $e;
 		}
 	}
 

src/FeedRegistration.php

@@ -82,8 +82,9 @@ public function init() {
 	 *
 	 * @return bool
 	 *
-	 * @throws Exception PHP Exception.
-	 * @throws PinterestApiException Pinterest API Exception.
+	 * @throws PinterestApiLocaleException Pinterest API does not support the locale.
+	 * @throws PinterestApiException       Pinterest API exception.
+	 * @throws Throwable                   Any other exception.
 	 */
 	public function handle_feed_registration(): bool {
 
@@ -97,26 +98,19 @@ public function handle_feed_registration(): bool {
 		}
 
 		try {
-			if ( self::register_feed() ) {
-				return true;
-			}
-			throw new Exception( esc_html__( 'Could not register feed.', 'pinterest-for-woocommerce' ) );
+			return self::register_feed();
 		} catch ( PinterestApiLocaleException $e ) {
 			Pinterest_For_Woocommerce()::save_data( 'merchant_locale_not_valid', true );
 
 			// translators: %s: Error message.
-			$error_message = "Could not register feed. Error: {$e->getMessage()}";
+			$error_message = "Could not register the feed. Error: {$e->getMessage()}";
 			self::log( $error_message, 'error' );
-			return false;
+			throw $e;
 		} catch ( PinterestApiException $e ) {
 			throw $e;
 		} catch ( Throwable $th ) {
-			if ( method_exists( $th, 'get_pinterest_code' ) && 4163 === $th->get_pinterest_code() ) {
-				Pinterest_For_Woocommerce()::save_data( 'merchant_connected_diff_platform', true );
-			}
-
 			self::log( $th->getMessage(), 'error' );
-			return false;
+			throw $th;
 		}
 	}