Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix #1213

Open
barryhughes opened this issue Oct 30, 2024 · 2 comments
Open

Update test matrix #1213

barryhughes opened this issue Oct 30, 2024 · 2 comments

Comments

@barryhughes
Copy link
Member

As soon as reasonably practical, we should evaluate if we can incorporate PHP 8.4 into our automated test matrix (and make any changes needed to support that).

@mikkamp
Copy link

mikkamp commented Nov 14, 2024

When testing with a plugin dependent on WooCommerce I get several deprecation messages when running on PHP 8.4.

deprecation messages
Deprecated: ActionScheduler_QueueCleaner::__construct(): Implicitly marking parameter $store as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/ActionScheduler_QueueCleaner.php on line 35
Deprecated: ActionScheduler_Abstract_QueueRunner::__construct(): Implicitly marking parameter $cleaner as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Abstract_QueueRunner.php on line 34
Deprecated: ActionScheduler_QueueRunner::__construct(): Implicitly marking parameter $async_request as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/ActionScheduler_QueueRunner.php on line 40
Deprecated: ActionScheduler_Action::__construct(): Implicitly marking parameter $schedule as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/actions/ActionScheduler_Action.php on line 37
Deprecated: ActionScheduler_ActionFactory::get_stored_action(): Implicitly marking parameter $schedule as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/ActionScheduler_ActionFactory.php on line 21
Deprecated: ActionScheduler_DBLogger::log(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBLogger.php on line 21
Deprecated: ActionScheduler_DBStore::claim_actions(): Implicitly marking parameter $before_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php on line 863
Deprecated: ActionScheduler_DBStore::stake_claim(): Implicitly marking parameter $before_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php on line 798
Deprecated: ActionScheduler_DBStore::save_action_to_db(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php on line 82
Deprecated: ActionScheduler_DBStore::save_action(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php on line 68
Deprecated: ActionScheduler_DBStore::save_unique_action(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php on line 55
Deprecated: ActionScheduler_DBStoreMigrator::save_action(): Implicitly marking parameter $last_attempt_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/migration/ActionScheduler_DBStoreMigrator.php on line 26
Deprecated: ActionScheduler_Logger::log_failed_fetch_action(): Implicitly marking parameter $exception as nullable is deprecated, the explicit nullable type must be used instead in /tmp/woocommerce-9.4.1/plugins/woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Logger.php on line 213
Deprecated: ActionScheduler_Logger::log(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Logger.php on line 34
Deprecated: ActionScheduler_wpCommentLogger::log(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in /tmp/woocommerce-9.4.1/plugins/woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_wpCommentLogger.php on line 19
Deprecated: ActionScheduler_wpPostStore::claim_actions(): Implicitly marking parameter $before_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_wpPostStore.php on line 634
Deprecated: ActionScheduler_wpPostStore::stake_claim(): Implicitly marking parameter $before_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_wpPostStore.php on line 585
Deprecated: ActionScheduler_wpPostStore::create_post_array(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_wpPostStore.php on line 61
Deprecated: ActionScheduler_wpPostStore::save_action(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_wpPostStore.php on line 38
Deprecated: ActionScheduler_HybridStore::save_action(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_HybridStore.php on line 246
Deprecated: ActionScheduler_HybridStore::stake_claim(): Implicitly marking parameter $before_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_HybridStore.php on line 216
Deprecated: ActionScheduler_HybridStore::__construct(): Implicitly marking parameter $config as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_HybridStore.php on line 43
Deprecated: ActionScheduler_Store::get_scheduled_date_string_local(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Store.php on line 303
Deprecated: ActionScheduler_Store::get_scheduled_date_string(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Store.php on line 286
Deprecated: ActionScheduler_Store::stake_claim(): Implicitly marking parameter $before_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Store.php on line 198
Deprecated: ActionScheduler_Store::save_action(): Implicitly marking parameter $scheduled_date as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/abstracts/ActionScheduler_Store.php on line 29
Deprecated: ActionScheduler_Schedule::next(): Implicitly marking parameter $after as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/classes/schedules/ActionScheduler_Schedule.php on line 11
Deprecated: ActionScheduler_Schedule_Deprecated::next(): Implicitly marking parameter $after as nullable is deprecated, the explicit nullable type must be used instead in woocommerce/packages/action-scheduler/deprecated/ActionScheduler_Schedule_Deprecated.php on line 16

Now that the minimum version has been bumped to 7.1, these should all be fixable by making the parameter type nullable.

Edit: I found the PR which fixes these issues: #1205

@barryhughes
Copy link
Member Author

Edit: I found the PR which fixes these issues: #1205

Right, so that should ship in Action Scheduler 3.9.0. However, given the context (your 'true' dependency is WooCommerce), it's worth noting WooCommerce tends to lag one or two versions behind (because of differences in release cadence).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants