From 7f13a517dc4976ab022174c7b2e317d80a57f04a Mon Sep 17 00:00:00 2001 From: Aaron Rosenzweig Date: Thu, 7 Feb 2013 18:59:18 -0500 Subject: [PATCH 1/2] "disabled" feature These components can now be disabled. Signed-off-by: Aaron Rosenzweig --- .../Components/ERXRadioButtonMatrix.api | 2 +- .../ERXRadioButtonMatrix.html | 2 +- .../ERXRadioButtonMatrix.wod | 9 +++++++++ .../components/ERXRadioButtonMatrix.java | 8 ++++---- .../WOCheckboxMatrix.wo/WOCheckboxMatrix.html | 2 +- .../WOCheckboxMatrix.wo/WOCheckboxMatrix.wod | 19 ++++++++++++++++++- 6 files changed, 34 insertions(+), 8 deletions(-) diff --git a/Frameworks/Core/ERExtensions/Components/ERXRadioButtonMatrix.api b/Frameworks/Core/ERExtensions/Components/ERXRadioButtonMatrix.api index 4e07225166b..df6f7536469 100644 --- a/Frameworks/Core/ERExtensions/Components/ERXRadioButtonMatrix.api +++ b/Frameworks/Core/ERExtensions/Components/ERXRadioButtonMatrix.api @@ -26,6 +26,6 @@ - + diff --git a/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.html b/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.html index f37c3aa92d9..bd1b5fa1ca4 100644 --- a/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.html +++ b/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.html @@ -1 +1 @@ -
\ No newline at end of file +
\ No newline at end of file diff --git a/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.wod b/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.wod index 9266efc7551..2d0947ed793 100644 --- a/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.wod +++ b/Frameworks/Core/ERExtensions/Components/Nonlocalized.lproj/ERXRadioButtonMatrix.wo/ERXRadioButtonMatrix.wod @@ -9,6 +9,15 @@ RadioButton: WOGenericElement { value = index; } +RadioButtonDisabled: WOGenericElement { + elementName = "input"; + name = uniqueID; + otherTagString = isCurrentItemSelected; + type = "radio"; + value = index; + disabled = true; +} + RadioButtonRepetition: ERXTable { cellpadding = cellpadding; cellspacing = cellspacing; diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/components/ERXRadioButtonMatrix.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/components/ERXRadioButtonMatrix.java index c1e9c2aee9e..0da70404267 100644 --- a/Frameworks/Core/ERExtensions/Sources/er/extensions/components/ERXRadioButtonMatrix.java +++ b/Frameworks/Core/ERExtensions/Sources/er/extensions/components/ERXRadioButtonMatrix.java @@ -67,6 +67,10 @@ public void setCurrentItem(Object aValue) { public Number index() { return index; } + + public boolean disabled() { + return booleanValueForBinding("disabled", false); + } public void setIndex(Number newIndex) { index = newIndex; @@ -107,10 +111,6 @@ public String otherTagStringForRadioButton() { return (isDisabled ? "disabled" : "") + (isDisabled && isChecked? " " : "") + (isChecked ? "checked" : ""); } - public boolean disabled() { - return booleanValueForBinding("disabled", false); - } - @Override public void awake() { super.awake(); diff --git a/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.html b/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.html index d2edfe884c4..987b3f0b3c7 100644 --- a/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.html +++ b/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.html @@ -1,5 +1,5 @@ -
+
diff --git a/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.wod b/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.wod index 814fe32a61c..9bbfe9e1d6c 100644 --- a/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.wod +++ b/Frameworks/Core/JavaWOExtensions/Components/Nonlocalized.lproj/WOCheckboxMatrix.wo/WOCheckboxMatrix.wod @@ -1,4 +1,12 @@ - +isDisabledConditional : WOConditional { + condition = ^disabled; +} + +isEnabledConditional : WOConditional { + condition = ^disabled; + negate = true; +} + CheckBox: WOGenericElement { elementName = "input"; name = wrapperElementID; @@ -7,6 +15,15 @@ CheckBox: WOGenericElement { value = index; } +disabledCheckBox: WOGenericElement { + elementName = "input"; + name = wrapperElementID; + otherTagString = isCurrentItemChecked; + type = "checkbox"; + value = index; + disabled = "disabled"; +} + CheckBoxRepetition: WOTable { cellpadding = 0; cellspacing = 0; From 373cd81119272b1f6619cd2daf9a836f617b9fed Mon Sep 17 00:00:00 2001 From: Aaron Rosenzweig Date: Fri, 8 Feb 2013 10:23:06 -0500 Subject: [PATCH 2/2] Forgot to add "disabled" to .api file in recent commit. Signed-off-by: Aaron Rosenzweig --- .../Core/JavaWOExtensions/Components/WOCheckboxMatrix.api | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Frameworks/Core/JavaWOExtensions/Components/WOCheckboxMatrix.api b/Frameworks/Core/JavaWOExtensions/Components/WOCheckboxMatrix.api index 3f5b77fb336..52eaee1440c 100644 --- a/Frameworks/Core/JavaWOExtensions/Components/WOCheckboxMatrix.api +++ b/Frameworks/Core/JavaWOExtensions/Components/WOCheckboxMatrix.api @@ -1,4 +1,4 @@ - + @@ -15,5 +15,6 @@ - - \ No newline at end of file + + +