From 6eb39a6082e6986a94f7af93f25c9a5f2016cdda Mon Sep 17 00:00:00 2001 From: Johann Werner Date: Thu, 15 Nov 2012 21:59:38 +0100 Subject: [PATCH] instead of string concatenation move single quotes to format string as the formatter is only used for formatting we are safe to include the single quotes --- .../com/webobjects/jdbcadaptor/PostgresqlExpression.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Frameworks/PlugIns/PostgresqlPlugIn/Sources/com/webobjects/jdbcadaptor/PostgresqlExpression.java b/Frameworks/PlugIns/PostgresqlPlugIn/Sources/com/webobjects/jdbcadaptor/PostgresqlExpression.java index 2f2fce99438..2f132bad2ee 100644 --- a/Frameworks/PlugIns/PostgresqlPlugIn/Sources/com/webobjects/jdbcadaptor/PostgresqlExpression.java +++ b/Frameworks/PlugIns/PostgresqlPlugIn/Sources/com/webobjects/jdbcadaptor/PostgresqlExpression.java @@ -75,7 +75,7 @@ public class PostgresqlExpression extends JDBCExpression { private static final ThreadLocal DATE_FORMATTER = new ThreadLocal() { @Override protected SimpleDateFormat initialValue() { - return new SimpleDateFormat("yyyy-MM-dd"); + return new SimpleDateFormat("''yyyy-MM-dd''"); } }; @@ -85,7 +85,7 @@ protected SimpleDateFormat initialValue() { private static final ThreadLocal TIMESTAMP_FORMATTER = new ThreadLocal() { @Override protected SimpleDateFormat initialValue() { - return new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS"); + return new SimpleDateFormat("''yyyy-MM-dd HH:mm:ss.SSS''"); } }; @@ -444,9 +444,9 @@ public String formatValueForAttribute(Object obj, EOAttribute eoattribute) { if(obj instanceof NSData) { value = sqlStringForData((NSData)obj); } else if((obj instanceof NSTimestamp) && isTimestampAttribute(eoattribute)) { - value = "'" + TIMESTAMP_FORMATTER.get().format(obj) + "'"; + value = TIMESTAMP_FORMATTER.get().format(obj); } else if((obj instanceof NSTimestamp) && isDateAttribute(eoattribute)) { - value = "'" + DATE_FORMATTER.get().format(obj) + "'"; + value = DATE_FORMATTER.get().format(obj); } else if(obj instanceof String) { value = formatStringValue((String)obj); } else if(obj instanceof Number) {