-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Year-Wise tab should have their own url #108
Comments
Are you sure? I don't think this is correct in practice. 😕 |
Events are pretty less. Overkill lag raha hai 👀 |
I think @ydidwania had achieved this before. Can you find out what broke it and fix it? 🙂 |
Right now we are loading everything(all events) and tabbing them |
I agree with grub, @Nihal isn't that done for different pages 😕 |
Yeah, I agree it's not exactly the "right" way. But to do that with different pages, you need to have a backend that understands the GET request parameters. Since we are using Jekyll, if we want to do this, it'd have to be the Javascript way. About whether or not we need it, we do have a good number of tabs. It might be a good idea to have a different link for each one of them to ease sharing. Kind of like how the part after the |
If we click on a certain year's tab in events, the url remains the same http://wncc-iitb.org/events/
It would be better if the link is something like http://wncc-iitb.org/events/year?=2016 or something. I remember someone did it before.
The text was updated successfully, but these errors were encountered: