Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Display wallet creation date at installer and in settings #805

Open
kloaec opened this issue Nov 7, 2023 · 3 comments · May be fixed by #943
Open

[GUI] Display wallet creation date at installer and in settings #805

kloaec opened this issue Nov 7, 2023 · 3 comments · May be fixed by #943
Assignees
@pythcoiner
Labels
Feature New feature or functionality. GUI gui related In discussion Not ready for implementation. It is still being discussed whether we should address this issue.

Comments

@kloaec
Copy link
Collaborator

kloaec commented Nov 7, 2023

Core know the wallet creation date, a user should:

  • write it down, probably at the same time as they backup their descriptor
  • be able to find it on the settings too.
@darosior darosior added Good first issue Good for newcomers GUI gui related Feature New feature or functionality. labels Nov 7, 2023
@darosior
Copy link
Member

darosior commented Nov 7, 2023

Yeah it would be nice to know the wallet creation date in the "wallet" section of the settings in the GUI.

We shouldn't get it from bitcoind though but from our own database:

liana/src/database/sqlite/schema.rs

Lines 21 to 31 in d5b7a3a

/* This stores metadata about our wallet. We only support single wallet for
* now (and the foreseeable future).
*
* The 'timestamp' field is the creation date of the wallet. We guarantee to have seen all
* information related to our descriptor(s) that occured after this date.
* The optional 'rescan_timestamp' field is a the timestamp we need to rescan the chain
* for events related to our descriptor(s) from.
*/
CREATE TABLE wallets (
id INTEGER PRIMARY KEY NOT NULL,
timestamp INTEGER NOT NULL,

An approach to this would be to:

  1. Include this field in the getinfo RPC command
  2. Display this field in the "wallet" section of the settings in the GUI by calling getinfo.

@pythcoiner
Copy link
Collaborator

I can tackle that, but not sure I can deliver for v4

@darosior
Copy link
Member

Related to #620.

@pythcoiner pythcoiner self-assigned this Dec 11, 2023
@pythcoiner pythcoiner mentioned this issue Jan 14, 2024
Merged
3 tasks
darosior added a commit that referenced this issue Jan 23, 2024
@darosior
Merge #920: Wallet creation time
e9b5a7a 
7917794 add timestamp field to getinfo (pythcoiner)

Pull request description:

  (partially) address #805
  - [x] daemon
  - [x] tests
  - [x] doc

ACKs for top commit:
  darosior:
    ACK 7917794

Tree-SHA512: ee72761174a09871092fe13313e18180530c1a9c4ef5ddf63cb196760a67bc4bac3c9af134d4be5e464f1ac0e16fed726693340499d192eb9a4d68471bbc2ced
This was referenced Jan 29, 2024
Closed
Open
@darosior darosior added In discussion Not ready for implementation. It is still being discussed whether we should address this issue. and removed Good first issue Good for newcomers labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pythcoiner pythcoiner

Labels
Feature New feature or functionality. GUI gui related In discussion Not ready for implementation. It is still being discussed whether we should address this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GUI] display wallet birthday pythcoiner/liana
3 participants
@kloaec @darosior @pythcoiner