Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grey out next button if no recovery path availables #1102

Open
pythcoiner opened this issue Jun 4, 2024 · 3 comments · May be fixed by #1144
Open

Grey out next button if no recovery path availables #1102

pythcoiner opened this issue Jun 4, 2024 · 3 comments · May be fixed by #1144
Assignees
@pythcoiner
Labels
Enhancement Improving an existing functionality GUI gui related Nice to have If it's not completed in time for the current version, it can be postponed
Milestone
v9 Liana - Candid...

Comments

@pythcoiner
Copy link
Collaborator

image
If no recovery path available we still can select coins and click next, then an error is triggered , i think we should at least grey-out the next button.

nit: we should named the error, its not unknown as we have the right description.
@nondiremanuel nondiremanuel added GUI gui related Enhancement Improving an existing functionality labels Jun 4, 2024
@pythcoiner
Copy link
Collaborator Author

@edouardparis, it looks to me this issue can only happen when there is only 1 block left before we can spend (see here), recovery paths are filtered by checking if there is less or 1 block left, shouldn't we filter out if 1 block left to avoid this error?

@pythcoiner pythcoiner linked a pull request Jun 27, 2024 that will close this issue
Open
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Jun 27, 2024
@nondiremanuel nondiremanuel added the Nice to have If it's not completed in time for the current version, it can be postponed label Jun 27, 2024
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Jul 9, 2024

@edouardparis, it looks to me this issue can only happen when there is only 1 block left before we can spend (see here), recovery paths are filtered by checking if there is less or 1 block left, shouldn't we filter out if 1 block left to avoid this error?

Note the createrecovery command selects all coins that are recoverable at the next block. If we stick to the same approach in the GUI, we would probably need instead to prevent the transaction being broadcast too soon.

But it seems simpler to change the filter to select only those coins currently recoverable (as in your PR).

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Jul 29, 2024

Were the coins unconfirmed when you got the error?

@nondiremanuel nondiremanuel modified the milestones: v7 - Liana, v8 - Liana Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pythcoiner pythcoiner

Labels
Enhancement Improving an existing functionality GUI gui related Nice to have If it's not completed in time for the current version, it can be postponed
Projects
Liana General
Status: In Review
Milestone
v9 Liana - Candidates
Development

Successfully merging a pull request may close this issue.

Do not let user try recovery if one block left pythcoiner/liana
3 participants
@nondiremanuel @jp1ac4 @pythcoiner