fix(android): grant all permissions after resetting app state

Author: noomorph

detox/src/devices/common/drivers/android/exec/ADB.js

@@ -160,6 +160,14 @@ class ADB {
     }
   }
 
+  async grantAllPermissions(deviceId, packageId) {
+    await this.shell(deviceId, `pm grant --all-permissions ${packageId}`);
+  }
+
+  async revokeAllPermissions(deviceId, packageId) {
+    await this.shell(deviceId, `pm revoke --all-permissions ${packageId}`);
+  }
+
   async setLocation(deviceId, lat, lon) {
     // NOTE: QEMU for Android for the telnet part relies on C stdlib
     // function `strtod` which is locale-sensitive, meaning that depending

detox/src/devices/common/drivers/android/exec/ADB.test.js

@@ -429,4 +429,24 @@ describe('ADB', () => {
       await expect(adb.clearAppData(deviceId, 'com.example.app')).rejects.toThrowErrorMatchingSnapshot();
     });
   });
+
+  describe('grantAllPermissions', () => {
+    it('should invoke pm grant --all-permissions for given package', async () => {
+      await adb.grantAllPermissions(deviceId, 'com.example.app');
+      expect(execWithRetriesAndLogs).toHaveBeenCalledWith(
+        expect.stringContaining(`"${adbBinPath}" -s ${deviceId} shell "pm grant --all-permissions com.example.app"`),
+        expect.any(Object)
+      );
+    });
+  });
+
+  describe('revokeAllPermissions', () => {
+    it('should invoke pm revoke --all-permissions for given package', async () => {
+      await adb.revokeAllPermissions(deviceId, 'com.example.app');
+      expect(execWithRetriesAndLogs).toHaveBeenCalledWith(
+        expect.stringContaining(`"${adbBinPath}" -s ${deviceId} shell "pm revoke --all-permissions com.example.app"`),
+        expect.any(Object)
+      );
+    });
+  });
 });

detox/src/devices/runtime/drivers/android/AndroidDriver.js

@@ -87,6 +87,7 @@ class AndroidDriver extends DeviceDriverBase {
   async resetAppState(...bundleIds) {
     for (const bundleId of bundleIds) {
       await this.adb.clearAppData(this.adbName, bundleId);
+      await this.adb.grantAllPermissions(this.adbName, bundleId);
     }
   }
 

detox/src/devices/runtime/drivers/android/AndroidDriver.test.js

@@ -496,6 +496,16 @@ describe('Android driver', () => {
       expect(adb.clearAppData).toHaveBeenCalledWith(adbName, bundleId1);
       expect(adb.clearAppData).toHaveBeenCalledWith(adbName, bundleId2);
     });
+
+    it('should grant all permissions for the affected apps', async () => {
+      const bundleId1 = 'com.example.app1';
+      const bundleId2 = 'com.example.app2';
+
+      await uut.resetAppState(bundleId1, bundleId2);
+
+      expect(adb.grantAllPermissions).toHaveBeenCalledWith(adbName, bundleId1);
+      expect(adb.grantAllPermissions).toHaveBeenCalledWith(adbName, bundleId2);
+    });
   });
 
   describe('text-typing (global)', () => {