Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - CommentElement don't have querySelector function #73

Open
hepiyellow opened this issue Apr 17, 2019 · 0 comments
Open

Issue - CommentElement don't have querySelector function #73

hepiyellow opened this issue Apr 17, 2019 · 0 comments

Comments

@hepiyellow
Copy link
Contributor

Use case

In WSR we have a table, that when it has no data, it renders null to the dom.
React (15) renders null as a Comment Element.

Comment elements don't have querySelector or querySelectorAll.

I encountered one of our tests which failed on this line:
return Array.from(e.querySelectorAll(selector));

return Array.from(e.querySelectorAll(selector));

Expected Behavior

Well, I guess the only thing we could do better,
is print out a more informative error (instead of TypeError: e.querySelectorAll is not a function)

we can have:
$$ unsupported for element of type comment`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant