Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protractor adapter - hasClass implementation is wrong #53

Open
NitayRabi opened this issue Mar 14, 2019 · 1 comment
Open

Protractor adapter - hasClass implementation is wrong #53

NitayRabi opened this issue Mar 14, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@NitayRabi
Copy link

NitayRabi commented Mar 14, 2019

When using class list, the adapter uses element.getAttribute('classList') - this does not work.

(https://github.com/wix-incubator/unidriver/blob/master/adapters/protractor/src/index.ts#L117)

Example from DOM -
image

Implementation can be based on class/className attribute

see https://stackoverflow.com/questions/20268128/how-to-test-if-an-element-has-class-using-protractor

@GabiGrin
Copy link
Contributor

oh bummer, and this adapter is also not being tested with the test suite.
@NitayRabi do you guys wanna help with this? both the fix and connecting the protractor adapter to the test suite?

PS: I do plan to remove it altogether (#49)

@GabiGrin GabiGrin added the bug Something isn't working label Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants