Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/vue integration doesn't have documentation on using multiple JSX renderers #10685

Open
louisescher opened this issue Jan 10, 2025 · 2 comments
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) should this be documented? Need to figure out whether this is something to add to documentation or not

Comments

@louisescher
Copy link
Contributor

📚 Subject area/topic

Integrations / UI Frameworks

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/en/guides/integrations-guide/vue/

📋 Description of content that is out-of-date or incorrect

The documentation page for Vue doesn't feature the same text about combining multiple JSX frameworks like all other integrations that allow JSX rendering do.
Adding a subsection to the JSX section would probably be best, since Vue doesn't have to be used to render JSX.
See this comment in #12887 (withastro/astro) for more info on why this might be needed.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@louisescher louisescher added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 10, 2025
@sarah11918
Copy link
Member

@louisescher So, one issue is that @bluwy says we haven't yet tested whether this in fact works with mixed JSX libraries like the others, and if it has issues with includes/excludes.

It feels a bit premature to add this to docs and say "Do this" if we don't know that it works? And therefore are we sure about adding Vue to the warnings in Astro 12887?

If we don't in fact know whether/how this works yet, then the fact that "JSX is possible in Vue with a Vite plugin" might not be enough for us to document it?

Also cc @florian-lefebvre re: my concerns here

@sarah11918 sarah11918 added the should this be documented? Need to figure out whether this is something to add to documentation or not label Jan 10, 2025
@sarah11918
Copy link
Member

One reason for my hesitation is that my initial suggest would have been to update and reuse the standard section we already have:

Combining multiple JSX frameworks
When you are using multiple JSX frameworks (React, Preact, Solid, Vue [with the JSX plugin](link to plugin)) in the same project...

I'm not entirely convinced that this feels like something ready to be added in that way? So that's why I want to confirm. I would rather not mention JSX in Vue at all if we don't in fact know that our strategy for combining mulitple JSX frameworks is also applicable when using Vue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) should this be documented? Need to figure out whether this is something to add to documentation or not
Projects
None yet
Development

No branches or pull requests

2 participants