[bugfix] Make sure loop connected pins are not hidden #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvid
force-pushed
the
issue263-unhide-loops
branch
from
270b677
to
40a8516
Compare
kvid
added a commit
to kvid/WireViz
that referenced
this pull request
Sep 1, 2023
- Resolves wireviz#263 that describes warnings and weird loop drawing because loop connected pins are hidden when hide_disconnected_pins=True. - Activate loop pins as early as possible to enable correct counting of connected pins when connector.additional_components.qty_multiplier=populated. - Check that loop pins actually exist before activating them.
kvid
force-pushed
the
issue263-unhide-loops
branch
from
40a8516
to
6aa0c58
Compare
- Resolves wireviz#263 that describes warnings and weird loop drawing because loop connected pins are hidden when hide_disconnected_pins=True. - Activate loop pins as early as possible to enable correct counting of connected pins when connector.additional_components.qty_multiplier=populated. - Check that loop pins actually exist before activating them.
kvid
force-pushed
the
issue263-unhide-loops
branch
from
6aa0c58
to
9a39de0
Compare
formatc1702
approved these changes
Sep 7, 2023
No need to reference github issue in the code. Co-authored-by: Daniel Rojas <[email protected]>
kvid
force-pushed
the
issue263-unhide-loops
branch
from
8dc0023
to
f73dd48
Compare
kvid
added a commit
that referenced
this pull request
Sep 8, 2023
- Resolves #263 that describes warnings and weird loop drawing because loop connected pins are hidden when hide_disconnected_pins=True. - Activate loop pins as early as possible to enable correct counting of connected pins when connector.additional_components.qty_multiplier=populated. - Check that loop pins actually exist before activating them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hide_disconnected_pins=True.connector.additional_components.qty_multiplier=populated.I suggest a squash merge with the bullets above in the commit message body, and this commit message title: