Skip to content

Commit c86bd35

Browse files
vladislavPVVladislav Paciu
andauthored
fix(karma): add resources to kthxbye sidecar (#761)
Co-authored-by: Vladislav Paciu <[email protected]>
1 parent a5c9e2a commit c86bd35

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

charts/karma/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ home: https://github.com/prymitive/karma
66
sources:
77
- https://github.com/wiremind/wiremind-helm-charts/tree/main/charts/karma
88
- https://github.com/prymitive/karma
9-
version: 2.10.0
9+
version: 2.11.0
1010
kubeVersion: ">= 1.19-0"
1111
appVersion: "v0.121"
1212
maintainers:

charts/karma/templates/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ spec:
116116
{{- if .Values.kthxbyeSidecar.logJson }}
117117
- --log-json
118118
{{- end }}
119+
resources:
120+
{{ toYaml .Values.kthxbyeSidecar.resources | indent 12 }}
119121
{{- if .Values.kthxbyeSidecar.securityContext }}
120122
securityContext:
121123
{{ toYaml .Values.kthxbyeSidecar.securityContext | indent 12 }}

charts/karma/values.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,18 @@ kthxbyeSidecar:
229229
# max-duration: <duration> # Maximum duration of a silence, it won't be extended anymore after reaching it
230230
logJson: false
231231
securityContext: {}
232+
resources:
233+
{}
234+
## We usually recommend not to specify default resources and to leave this as a conscious
235+
## choice for the user. This also increases chances charts run on environments with little
236+
## resources, such as Minikube. If you do want to specify resources, uncomment the following
237+
## lines, adjust them as necessary, and remove the curly braces after 'resources:'.
238+
# limits:
239+
# cpu: 100m
240+
# memory: 128Mi
241+
# requests:
242+
# cpu: 100m
243+
# memory: 128Mi
232244

233245
# additional sidecar containers array which will be added to the deployment
234246
sidecarContainers: []

0 commit comments

Comments
 (0)