-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transactions table overflows off the screen due to long reference ID #10
Comments
I had a better idea: Looking at this though, it seems the customer ID is rarely populated https://docs.stripe.com/api/checkout/sessions/object#checkout_session_object-customer only if the customer_creation is set to always.. but customer_email is populated so I'm not sure why. If thats due to the webhook being used? |
Yes Stripe seems weird about it. I'm not using a different theme or modified the CSS, so I'm not sure why there's a difference, maybe my font size is bigger or something, with how my browser/pc is setup. I think the easiest option for now would be to trunk the reference ID or not have any reference ID at all, because it would be unnecessary and hard for us to modify the CSS of the table to accept longer fields. And emails are not unique so cannot use them. The ideal way would be using the customer ID but Stripe is weird and it would require an extra database operation, which we should avoid if possible. In the future, this could always be an option that people can change if it ever becomes a problem for some reason, that the reference ID is trunked. |
What worries me now is we are fixing a problem in a way that might not be the problem itself and we are breaking an existing field. It sounds like a Blesta UI issue rather than the plugin handles it. |
Moved from #7
The Blesta admin client profile transactions table clips off the screen because of the long reference ids, and that hides the date and edit button.
My suggestion is to use the email address provided by Stripe and fallback to the ID when no email is provided. (not using real numbers, dont worry)
You can also see how the Blesta PayPal gateway does it too, I was using them previously - they use email address.
What it looks like with my suggested change
I understand email not being as unique but the transaction ID is already provided (That's what the "pi_" number is), which is what Stripe use to identify payments, you can see that by going to your Payments view in the Stripe dashboard.
At least, I don't think the checkout session ID should be used, Stripe doesn't normally provide that(You have to dig around in the events and logs section to find it), they're very long, and Stripe doesn't provide a filter for it which makes them hard to use.
The text was updated successfully, but these errors were encountered: