feat: make syncV2 available for apiVersion 7 - WPB-21456 (#3811)

Author: netbe

WireNetwork/Sources/WireNetwork/Models/API/APIVersion.swift

@@ -76,3 +76,7 @@ public enum APIVersion: UInt, CaseIterable, Comparable, Sendable {
 }
 
 // swiftlint:enable identifier_name
+
+public extension APIVersion {
+    static let minimumSyncV2CompatibleVersion: APIVersion = .v7
+}

wire-ios-share-engine/Sources/SharingSessionLoader.swift

@@ -249,7 +249,7 @@ public struct SharingSessionLoader {
 
     // TODO: [WPB-17732] de-duplicate when implementing NSE
     private func shouldEnableSyncV2(metadata: ResolvedBackendMetadata) -> Bool {
-        let isAvailable = metadata.apiVersion >= .v8
+        let isAvailable = metadata.apiVersion >= .minimumSyncV2CompatibleVersion
         let isAlreadyEnabled = journal[.isSyncV2Enabled]
         return isAvailable && !isAlreadyEnabled
     }

wire-ios-sync-engine/Source/SessionManager/SessionManager.swift

@@ -1037,7 +1037,7 @@ public final class SessionManager: NSObject, SessionManagerType {
         if let session = backgroundUserSessions[account.userIdentifier] {
             WireLogger.sessionManager.debug("Session for \(account) is already loaded")
             return session
-        } else if DeveloperFlag.multibackend.isOn {
+        } else {
             do {
                 let loader = try UserSessionLoader(
                     account: account,
@@ -1135,8 +1135,6 @@ public final class SessionManager: NSObject, SessionManagerType {
                 )
                 return nil
             }
-        } else {
-            return await setupUserSession(account: account)
         }
     }
 
@@ -1169,132 +1167,6 @@ public final class SessionManager: NSObject, SessionManagerType {
         }
     }
 
-    @MainActor
-    private func setupUserSession(account: Account) async -> ZMUserSession? {
-        let coreDataStack = CoreDataStack(
-            account: account,
-            applicationContainer: sharedContainerURL,
-            dispatchGroup: dispatchGroup,
-            localDomain: BackendInfo.domain,
-            isFederationEnabled: BackendInfo.isFederationEnabled
-        )
-
-        if coreDataStack.needsMigration {
-            await withCheckedContinuation { continuation in
-                guard let delegate else {
-                    continuation.resume()
-                    return
-                }
-                delegate.sessionManagerWillMigrateAccount {
-                    continuation.resume()
-                }
-            }
-        }
-
-        do {
-            try await coreDataStack.load()
-        } catch {
-            delegate?.sessionManagerDidFailToLoadDatabase(error: error)
-            return nil
-        }
-
-        let journal = Journal(
-            userID: account.userIdentifier,
-            storage: sharedUserDefaults
-        )
-
-        if shouldEnableSyncV2(journal: journal) {
-            await enableSyncV2(
-                journal: journal,
-                coreDataStack: coreDataStack
-            )
-        }
-
-        let userSession = startBackgroundSession(
-            for: account,
-            with: coreDataStack,
-            journal: journal,
-            logFilesProvider: logFilesProvider
-        )
-
-        let migrationService = userSession.makeAppVersionMigrationService()
-        if migrationService.isMigrationNeeded {
-            await delegate?.sessionManagerWillMigrateAccount()
-
-            do {
-                try await migrationService.performAppMigrations()
-            } catch {
-                WireLogger.session.error(
-                    "Failed to perform app version migrations: \(String(describing: error))"
-                )
-            }
-        }
-
-        var shouldTriggerSync = true
-        do {
-            try await userSession.migrateToConsumableNotificationsIfNeeded()
-        } catch ZMUserSessionError.selfClientNotReady {
-            // We skip trigger sync, because in this case (fresh login),
-            // we don't have a registered client yet, so no consumable capability
-            WireLogger.sync.warn("No consumable-notifications migrator available")
-            shouldTriggerSync = false
-        } catch {
-            return nil
-        }
-
-        if shouldTriggerSync {
-            await userSession.triggerSync()
-        }
-
-        return userSession
-    }
-
-    private func shouldEnableSyncV2(journal: Journal) -> Bool {
-        guard let apiVersion = BackendInfo.apiVersion else {
-            fatalError("api version unknown")
-        }
-
-        let isAvailable = apiVersion >= .v8
-        let isAlreadyEnabled = journal[.isSyncV2Enabled]
-        return isAvailable && !isAlreadyEnabled
-    }
-
-    private func enableSyncV2(
-        journal: Journal,
-        coreDataStack: CoreDataStack
-    ) async {
-        guard let localDomain = BackendInfo.domain else {
-            fatalError("local domain unknown")
-        }
-
-        let dao: UpdateEventMigratorDAOProtocol = if #available(iOS 17, *) {
-            ActorBasedUpdateEventMigratorDAO(context: coreDataStack.eventContext)
-        } else {
-            UpdateEventMigratorDAO(context: coreDataStack.eventContext)
-        }
-
-        let migrator = UpdateEventMigrator(
-            dao: dao,
-            localDomain: localDomain
-        )
-
-        do {
-            if try await migrator.isMigrationNeeded() {
-                try await migrator.migrateLegacyUpdateEvents()
-                // Since we only migrate some events, we require an
-                // initial sync to ensure we didn't miss updates.
-                journal[.isInitialSyncRequired] = true
-            } else {
-                WireLogger.sync.debug("no migration needed")
-            }
-
-            journal[.isSyncV2Enabled] = true
-
-        } catch {
-            WireLogger.sync.critical("failed to migrate update events: \(error)")
-        }
-    }
-
     private func clearCRLExpirationDates(for account: Account) {
         let repository = CRLExpirationDatesRepository(userID: account.userIdentifier)
         repository.removeAllExpirationDates()

wire-ios-sync-engine/Source/SessionManager/UserSessionLoader.swift

@@ -353,7 +353,7 @@ final class UserSessionLoader {
         metadata: ResolvedBackendMetadata,
         eventContext: NSManagedObjectContext
     ) async throws {
-        let isAvailable = metadata.apiVersion >= .v8
+        let isAvailable = metadata.apiVersion >= .minimumSyncV2CompatibleVersion
         let isAlreadyEnabled = journal[.isSyncV2Enabled]
         let shouldEnable = isAvailable && !isAlreadyEnabled
 

wire-ios/Wire Notification Service Extension/NotificationService.swift

@@ -111,7 +111,7 @@ final class NotificationService: UNNotificationServiceExtension {
             return nil
         }
 
-        if apiVersion >= .v8 {
+        if apiVersion >= APIVersion.minimumSyncV2CompatibleVersion {
             WireLogger.notifications.info(
                 "loading new notification service",
                 attributes: .safePublic