Fix default download URL path #7
Conversation
The download URL path for older versions seems to have changed. So, the download of artifacts results in a 404 for cases where a specific release version is being defined (see tasks 'Compose ... download url)'. The proposed adjustments aims to fix this issue. Note that if a release version is not defined explicitly, the proposed change still works, because the latest versions are placed in the archive folder, too.
There was a problem hiding this comment.
Some artifacts are inside https://dl.minio.io/server/minio/release/linux-amd64/ and some are inside the subfolder archive/. I suppose this will keep changing.
I'm not sure defaulting to the archive folder is a good idea, as that would break when trying to install the latest versions of minio.
Could you change this PR?
Suggestion: you can move these variables from vars/main.yml to defaults/main.yml then they become user-overrideable.
|
@jschaul moving these vars is IMHO not necessary, because with |
|
|
|
What's new in this PR?
Issues
The download URL path for older versions seems to have changed. So, the download of artifacts results in a 404 for cases where a specific release version is being defined (see tasks 'Compose ... download url').
Causes (Optional)
Apparently, things have been moved around on the download server.
Solutions
Update the default download URL path to reflect the current reality.
Dependencies (Optional)
None
Needs releases with:
None
Testing
By successfully applying the changed role to a cluster.
Notes (Optional)
Note that if a release version is not defined explicitly, the proposed change still works, because the latest versions are placed in the archive folder, too.
Attachments (Optional)
None